[ 
https://issues.apache.org/jira/browse/IGNITE-15696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425161#comment-17425161
 ] 

Vladislav Pyatkov commented on IGNITE-15696:
--------------------------------------------

Hi [~maliev] I looked to your PR and  have another opinion.
1) Got rid of the limitation on RaftOptions#applyBatch. It does not matter 
anymore.
2) Remove references of RaftOptions for the StripedDisruptorTest. It will be a 
test for StripedDisruptar as is.
3) All todoes of the test might be also reduced.

> NullPointerException in StripeEntryHandler
> ------------------------------------------
>
>                 Key: IGNITE-15696
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15696
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Mirza Aliev
>            Priority: Blocker
>              Labels: ignite-3
>             Fix For: 3.0.0-alpha3
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Temporary fix https://issues.apache.org/jira/browse/IGNITE-15663 introduced 
> NPE in {{org.apache.ignite.raft.jraft.core.FSMCallerImpl#runApplyTask}}, also 
> bug with logging has been found 
> {{org.apache.ignite.raft.jraft.disruptor.StripedDisruptor.StripeExceptionHandler}},
>  exception doesn't been propagated to logger
> Solution with NPE is to set true to {{endOfBatch}} field in 
> {{com.lmax.disruptor.EventHandler#onEvent}} in 
> {{org.apache.ignite.raft.jraft.disruptor.StripedDisruptor.StripeEntryHandler#onEvent}},
>  so we don't need to rely on 
> {{node.getOptions().getRaftOptions().getApplyBatch()}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to