[ 
https://issues.apache.org/jira/browse/IGNITE-15705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Lapin updated IGNITE-15705:
-------------------------------------
    Description: 
h3. Problem

Raft client timeout should be large enough for the operation to be performed 
even if it falls on several consecutive rounds of choosing a new leader of the 
raft group. Most of jraft timeouts are based on electionTimeoutMs.
{code:java}
// A follower would become a candidate if it doesn't receive any message
// from the leader in |election_timeout_ms| milliseconds
// Default: 1000 (1s)
private int electionTimeoutMs = 1000; // follower to candidate timeout

{code}
 For example both voteTime and electionTime use exact value of 
getElectionTimeoutMs (1000 ms):

{{}}
{code:java}
String name = "JRaft-VoteTimer-" + suffix;
        this.voteTimer = new RepeatedTimer(name, 
options.getElectionTimeoutMs(), timerFactory.getVoteTimer(name)) {...};

        name = "JRaft-ElectionTimer-" + suffix;
        electionTimer = new RepeatedTimer(name, options.getElectionTimeoutMs(), 
timerFactory.getElectionTimer(name)) {...};
{code}
{{}}

Going back to client timeout, seems that it should be greater than 
reasonableAmountOfElecionRounds(electionTime + networkTimeoutToRetrieveAcks).

So seems that we should check the value of “networkTimeoutToRetrieveAcks” and 
set client timeout to the corresponding value.

Not sure whether it’s a good idea but let’s also consider raft client timeout 
to be derivative of leader election timeout not only semantically but also 
within code:

{{}}
{code:java}
private static final int TIMEOUT = 10 * leaderElectionTimeout;{code}
{{}}

  was:TODO


> Investigate raft client timeouts
> --------------------------------
>
>                 Key: IGNITE-15705
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15705
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Kirill Gusakov
>            Priority: Critical
>              Labels: ignite-3
>
> h3. Problem
> Raft client timeout should be large enough for the operation to be performed 
> even if it falls on several consecutive rounds of choosing a new leader of 
> the raft group. Most of jraft timeouts are based on electionTimeoutMs.
> {code:java}
> // A follower would become a candidate if it doesn't receive any message
> // from the leader in |election_timeout_ms| milliseconds
> // Default: 1000 (1s)
> private int electionTimeoutMs = 1000; // follower to candidate timeout
> {code}
>  For example both voteTime and electionTime use exact value of 
> getElectionTimeoutMs (1000 ms):
> {{}}
> {code:java}
> String name = "JRaft-VoteTimer-" + suffix;
>         this.voteTimer = new RepeatedTimer(name, 
> options.getElectionTimeoutMs(), timerFactory.getVoteTimer(name)) {...};
>         name = "JRaft-ElectionTimer-" + suffix;
>         electionTimer = new RepeatedTimer(name, 
> options.getElectionTimeoutMs(), timerFactory.getElectionTimer(name)) {...};
> {code}
> {{}}
> Going back to client timeout, seems that it should be greater than 
> reasonableAmountOfElecionRounds(electionTime + networkTimeoutToRetrieveAcks).
> So seems that we should check the value of “networkTimeoutToRetrieveAcks” and 
> set client timeout to the corresponding value.
> Not sure whether it’s a good idea but let’s also consider raft client timeout 
> to be derivative of leader election timeout not only semantically but also 
> within code:
> {{}}
> {code:java}
> private static final int TIMEOUT = 10 * leaderElectionTimeout;{code}
> {{}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to