[
https://issues.apache.org/jira/browse/IGNITE-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431275#comment-17431275
]
Ignite TC Bot commented on IGNITE-15416:
----------------------------------------
{panel:title=Branch: [pull/9503/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9503/head] Base: [master] : New Tests
(6)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Basic 1{color} [[tests
5|https://ci.ignite.apache.org/viewLog.html?buildId=6231476]]
* {color:#013220}IgniteBasicTestSuite:
NoopCheckpointSpiLoggingTest.shouldLogAboutCheckpointsBeingDisabledOnCheckpointRemoval
- PASSED{color}
* {color:#013220}IgniteBasicTestSuite:
NoopCheckpointSpiLoggingTest.shouldOnlyLogOnceAboutCheckointsBeingDisabled -
PASSED{color}
* {color:#013220}IgniteBasicTestSuite:
NoopCheckpointSpiLoggingTest.shouldLogAboutCheckpointsBeingDisabledOnCheckpointSave
- PASSED{color}
* {color:#013220}IgniteBasicTestSuite:
NoopCheckpointSpiLoggingTest.shouldLogAboutCheckpointsBeingDisabledOnCheckpointLoad
- PASSED{color}
* {color:#013220}IgniteBasicTestSuite:
NoopCheckpointSpiLoggingTest.shouldNotLogAboutCheckpointsBeingDisabledAtStartup
- PASSED{color}
{color:#00008b}Compute (Grid){color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=6231445]]
* {color:#013220}IgniteBinaryObjectsComputeGridTestSuite:
GridInitializationLoggingSelfTest.givenCollisionResolutionIsDisabled_whenInitializing_thenShouldLogAtInfoLevel
- PASSED{color}
{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6231535&buildTypeId=IgniteTests24Java8_RunAll]
> False warnings from default Checkpoint and Collision SPIs
> ---------------------------------------------------------
>
> Key: IGNITE-15416
> URL: https://issues.apache.org/jira/browse/IGNITE-15416
> Project: Ignite
> Issue Type: Improvement
> Components: compute
> Affects Versions: 2.10
> Reporter: Alexey Kukushkin
> Assignee: Roman Puchkovskiy
> Priority: Major
> Attachments: NoopCheckpointSpi.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Single-JAR Apache Ignite (no other dependencies but {{ignite-core}}) displays
> the two below warnings from the Checkpoint and Collision SPIs:
> {noformat}
> WARNING: Checkpoints are disabled (to enable configure any GridCheckpointSpi
> implementation)
> WARNING: Collision resolution is disabled (all jobs will be activated upon
> arrival).
> {noformat}
> A "warning" must be something requiring attention from the Ignite users. That
> is not the case for those messages:
> * The {{Checkpoints are disabled}} message warns that the [save/load/remove
> compute job state
> API|https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/spi/checkpoint/CheckpointSpi.html]
> is not implemented and would not have any effect.
> Although that is useful information, not all the Ignite apps really use the
> checkpoint API and that means it is a false alarm for them since they have
> nothing to do with it.
> * The {{Collision resolution is disabled}} message says that the default
> "all jobs will be activated upon arrival" policy is applied. This does not
> seem like a problem at all since this policy might be OK for most users.
> Also, not all the apps use Ignite Compute API (although it might be used
> implicitly). Thus, this is also not a warning since most users have nothing
> to do with it.
> Enhance Ignite to display a warning only when the user has to act upon it:
> * Ignite might display the {{Checkpoints are disabled}} message only when
> the [save/load/remove compute job state
> API|https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/spi/checkpoint/CheckpointSpi.html]
> is really used like demonstrated in the attached enhanced
> [^NoopCheckpointSpi.java]
> * The The {{Collision resolution is disabled}} message is not a warning at
> all. Consider turning it to an INFO message or removing it and making sure
> the Ignite documentation clearly explains the default "all jobs will be
> activated upon arrival" policy.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
