[
https://issues.apache.org/jira/browse/IGNITE-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436792#comment-17436792
]
Yury Gerzhedovich edited comment on IGNITE-15754 at 11/1/21, 12:20 PM:
-----------------------------------------------------------------------
[~amashenkov], LGTM, except few comments in PR. I propose to introduce
TestUtils class and consistently rename keyRow < -- > row, keys < -- > rows
at RecordBinaryViewImpl
was (Author: jooger):
[~amashenkov], LGTM, except few comments in PR. I propose to introduce
TestUtils class and consistently rename keyRow <-> row, keys <-> rows at
RecordBinaryViewImpl
> Fix tuple marshaller exception handling.
> -----------------------------------------
>
> Key: IGNITE-15754
> URL: https://issues.apache.org/jira/browse/IGNITE-15754
> Project: Ignite
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha3
> Reporter: Andrey Mashenkov
> Assignee: Andrey Mashenkov
> Priority: Major
> Labels: UX, ignite-3, tech-debt
> Fix For: 3.0.0-alpha4
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> _Throws_ section is not declared for TupleMarshaller interface methods.
> However, implementation throws an internal SchemaMismatch exception,
> that passes to the user.
> Let's fix methods contracts, make the exception checked, and convert into a
> public one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
