[
https://issues.apache.org/jira/browse/IGNITE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239128#comment-15239128
]
Vladimir Ozerov edited comment on IGNITE-2979 at 4/13/16 12:16 PM:
-------------------------------------------------------------------
Pavel, my comments:
1) {{JavaObject}} - docs say "Gets or sets" while in fact you have only getters.
2) {{JavaObject}} - it seems you should check if properties passed in ctor are
not null. If they are null, empty dictionary should be set.
3) {{PlatformContinuousQueryImpl}} - it is better to use {{BinaryObject}}
instead of {{BinaryObjectImpl}} do decrease coupling between components. You
can get type ID as follows: {{BinaryObject.type().typeId()}}.
4) I cannot find tests for local continuous queries. Please ensure they are in
place. Ideally, we should repeat all distributed tests for local mode.
Vladimir.
was (Author: vozerov):
Pavel, my comments:
1) {{JavaObject}} - docs say "Gets or sets" which in fact you have only getters.
2) {{JavaObject}} - it seems you should check if properties passed in ctor are
not null. If they are null, empty dictionary should be set.
3) {{PlatformContinuousQueryImpl}} - it is better to use {{BinaryObject}}
instead of {{BinaryObjectImpl}} do decrease coupling between components. You
can get type ID as follows: {{BinaryObject.type().typeId()}}.
4) I cannot find tests for local continuous queries. Please ensure they are in
place. Ideally, we should repeat all distributed tests for local mode.
Vladimir.
> .NET: Implement Java-based continuous query remote filter.
> ----------------------------------------------------------
>
> Key: IGNITE-2979
> URL: https://issues.apache.org/jira/browse/IGNITE-2979
> Project: Ignite
> Issue Type: Sub-task
> Components: platforms
> Affects Versions: 1.5.0.final
> Reporter: Vladimir Ozerov
> Assignee: Pavel Tupitsyn
> Priority: Critical
> Labels: important
> Fix For: 1.6
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
