[
https://issues.apache.org/jira/browse/IGNITE-2864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239909#comment-15239909
]
Semen Boikov commented on IGNITE-2864:
--------------------------------------
Hi Anton,
I have some comments:
- I think correct way to resolve conflict is call CacheVersionConflictResolver
since it can do more then just version comparison
- you added 'flags' in GridDhtAtomicUpdateRequest but did not change
writeTo/readFrom methods, please fix and add test
- why in IgniteTxRemoteSingleStateImpl.stores you create HashSet with capacity
3 if you know in advance that there is only one store?
- please add tests with near cache and make sure 'batchStoreCommit' is not
called for near cache txs
- I think it is possible to implement IgniteTxRemoteStateImpl.stores more
efficiently (do not iterate over read entries, avoid any collections creations
if there are no stores, etc). Please also run some tx putAll benchmarks in
FULL_SYNC mode with backup to make sure there is no performance drop.
> Need update local store from primary and backups
> ------------------------------------------------
>
> Key: IGNITE-2864
> URL: https://issues.apache.org/jira/browse/IGNITE-2864
> Project: Ignite
> Issue Type: Bug
> Components: cache
> Reporter: Semen Boikov
> Assignee: Anton Vinogradov
> Fix For: 1.6
>
>
> Now cache local store is updated only from primary nodes, this means that
> data can be lost if primary node is not re-started after crash. Need fix it
> and update store from primaries and backups if store is local (for both tx
> and atomic caches).
> This test should work:
> - cache with 1 backup, two server nodes
> - execute cache put for key K
> - stop both nodes
> - restart only node which was backup for K
> - load data from local sore, update for K should be restored
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
