[
https://issues.apache.org/jira/browse/IGNITE-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442170#comment-17442170
]
Andrey Mashenkov commented on IGNITE-15377:
-------------------------------------------
[~agura], actually, I just want the assignee person would ensure a codestyle
check passed after using IDEA autoformat.
Now I feel like we are in a hurry to apply the new codestyle and don't go deep
enough to understand the codestyle config and how the config matches our meets.
AFAIK, we agree with the line length limit of 140, but I saw an original value
of 100 (fixed in IGNITE-15878.
Also, I see we allow missed javadocs for test methods (marked with @Test
annotation), but forget to do the same for parameterized tests
(@ParameterizedTest and @TestFactory)
and even @BeforeEach/BeforeAll/AfterEach/AfterAll.
Maybe, the best way is to put here some examples with the code here (e.g. from
IDEA setting).
The example should be perfectly formatted according to our expectations and
cover all the cases.
Using the examples the could make a correct PR and another one could easily
check PR correctness.
> [Ignite 3] Add config for IDEA with codestyle
> ---------------------------------------------
>
> Key: IGNITE-15377
> URL: https://issues.apache.org/jira/browse/IGNITE-15377
> Project: Ignite
> Issue Type: Improvement
> Components: documentation
> Affects Versions: 3.0.0-alpha2
> Reporter: Andrey Mashenkov
> Priority: Major
> Labels: ignite-3
>
> Let's add editor configuration for IDEA according to a new code style.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
