[ 
https://issues.apache.org/jira/browse/IGNITE-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449166#comment-17449166
 ] 

Vyacheslav Koptilin edited comment on IGNITE-15666 at 11/25/21, 12:34 PM:
--------------------------------------------------------------------------

Hi [~ivandasch],

> The mentioned paragraph is not about statistics per se, it is about counters 
> (integer numbers)
The paragraph is called: *12.4. Statistics Effects of Cache Operations* So, it 
definitely relates to statistics. One more time, there are no counters/metrics. 
The only thing that is used by specification is "statistic"

> Yes, it is logically correct. We should track both success and failures. And 
> spec is about the same.
I don't think so. _getCacheRemovals()_ returns number of *removals* (success 
removals in fact). getAverageRemoveTime() returns average time of *removal*. 
Why do you interpret the same term *removal* differently (in the first case, 
only success, in the second all removals)?

> Checked code, and by modifying specific test in EhCache – the same behaviour. 
> Latency monitor is updated for all outcomes.
I checked hazelcast implementation of JCache API and its behavior absolutely 
the same as Apache Ignite (without this fix of course)


was (Author: slava.koptilin):
Hi [~ivandasch],

> The mentioned paragraph is not about statistics per se, it is about counters 
> (integer numbers)
The paragraph is called: *12.4. Statistics Effects of Cache Operations* So, it 
definitely relates to statistics. One more time, there are not 
counters/metrics. The only thing that is used by specification is "statistic"

> Yes, it is logically correct. We should track both success and failures. And 
> spec is about the same.
I don't think so. _getCacheRemovals()_ returns number of *removals* (success 
removals in fact). getAverageRemoveTime() returns average time of *removal*. 
Why do you interpret the same term *removal* differently (in the first case, 
only success, in the second all removals)?

> Checked code, and by modifying specific test in EhCache – the same behaviour. 
> Latency monitor is updated for all outcomes.
I checked hazelcast implementation of JCache API and its behavior absolutely 
the same as Apache Ignite (without this fix of course)

> The remove metric value is different for sync and async methods
> ---------------------------------------------------------------
>
>                 Key: IGNITE-15666
>                 URL: https://issues.apache.org/jira/browse/IGNITE-15666
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Amelchev Nikita
>            Assignee: Amelchev Nikita
>            Priority: Major
>             Fix For: 2.12
>
>         Attachments: screenshot-1.png
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The remove metric value is different for sync and async methods.
> The following metrics are updated only if the key was exist for the sync 
> version:
> {noformat}
> RemoveTimeTotal
> RemoveTime
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to