[ 
https://issues.apache.org/jira/browse/IGNITE-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454418#comment-17454418
 ] 

Ignite TC Bot commented on IGNITE-16061:
----------------------------------------

{panel:title=Branch: [pull/9632/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9632/head] Base: [master] : No new tests 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6308435&buildTypeId=IgniteTests24Java8_RunAll]

> Make BinaryMarshaller#setBinaryContext() public
> -----------------------------------------------
>
>                 Key: IGNITE-16061
>                 URL: https://issues.apache.org/jira/browse/IGNITE-16061
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>            Reporter: Roman Puchkovskiy
>            Assignee: Roman Puchkovskiy
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> BinaryMarshaller#setBinaryContext() method is required to initialize 
> BinaryMarshaller, without this method invocation BinaryMarshaller cannot be 
> used. But the method is private and it never gets invoked from 
> BinaryMarshaller code itself. Instead, it is always called from other classes 
> using reflection, like this:
> IgniteUtils.invoke(BinaryMarshaller.class, bMarsh0, "setBinaryContext", 
> binaryCtx, ctx.config());
> So, in reality, the method is handled like it's public, but as it is actually 
> private, reflection has to be used as a work-around.
> It seems better to just make the method public.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to