[
https://issues.apache.org/jira/browse/IGNITE-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475288#comment-17475288
]
Ignite TC Bot commented on IGNITE-16150:
----------------------------------------
{panel:title=Branch: [pull/9724/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/9724/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=6364977&buildTypeId=IgniteTests24Java8_RunAll]
> Get rid of redundant copying of files after downloading when restoring a
> snapshot.
> -----------------------------------------------------------------------------------
>
> Key: IGNITE-16150
> URL: https://issues.apache.org/jira/browse/IGNITE-16150
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.12
> Reporter: Pavel Pereslegin
> Assignee: Pavel Pereslegin
> Priority: Major
> Labels: iep-43
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During the snapshot restore procedure after retrieving the partition file
> from the remote node, we create an additional copy of this file.
> {code:java}
> for (Map.Entry<UUID, Map<Integer, Set<Integer>>> m : snpAff.entrySet())
> {
> ctx.cache().context().snapshotMgr()
> .requestRemoteSnapshotFiles(m.getKey(),
> opCtx0.snpName,
> m.getValue(),
> opCtx0.stopChecker,
> (snpFile, t) -> {
> ...
> Path partFile =
> Paths.get(tmpCacheDir.getAbsolutePath(), snpFile.getName());
> try {
>
> IgniteSnapshotManager.copy(snpMgr.ioFactory(),
> snpFile,
> partFile.toFile(),
> snpFile.length());
> ...
> {code}
> File copying is redundant here and can have significant performance overhead.
> Instead, we have to download the file to the target directory (and rename it
> to the desired name if necessary).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
