[
https://issues.apache.org/jira/browse/IGNITE-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532160#comment-17532160
]
Anton Vinogradov edited comment on IGNITE-16916 at 5/5/22 9:54 AM:
-------------------------------------------------------------------
[[email protected]], [~sergeychugunov]
Looks like {{KillCommandsCommandShTest.testCancelComputeTask}} is
[broken|https://ci.ignite.apache.org/test/-8103382042071142009?currentProjectId=IgniteTests24Java8&branch=%3Cdefault%3E&expandTestHistoryChartSection=true]
now
!screenshot-1.png!
As far as I can see, you never checked these changes :(
!image-2022-05-05-12-46-26-543.png!
was (Author: av):
[[email protected]]
Looks like {{KillCommandsCommandShTest.testCancelComputeTask}} is
[broken|https://ci.ignite.apache.org/test/-8103382042071142009?currentProjectId=IgniteTests24Java8&branch=%3Cdefault%3E&expandTestHistoryChartSection=true]
now
!screenshot-1.png!
As far as I can see, you never checked these changes :(
!image-2022-05-05-12-46-26-543.png!
> Make nodes more resilient in case of a job cancellation
> -------------------------------------------------------
>
> Key: IGNITE-16916
> URL: https://issues.apache.org/jira/browse/IGNITE-16916
> Project: Ignite
> Issue Type: Task
> Components: compute
> Reporter: Kirill Tkalenko
> Assignee: Kirill Tkalenko
> Priority: Major
> Fix For: 2.14
>
> Attachments: image-2022-05-05-12-46-26-543.png, screenshot-1.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In case of a job being cancelled we currently have a really questionable
> approach.
> We are now setting the interruption flag even before we give a use a chance
> to stop the job gracefully.
> Proposal for the implementation:
> * Adding a distributed property in the metastore that will set a timeout for
> interrupting *GridJobWorker* that did not gracefully complete after calling
> *GridJobWorker#cancel*;
> * On the call of the *GridJobWorker#cancel*, do not *Thread#interrupt* the
> thread, but add *GridTimeoutObject*.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
