[ 
https://issues.apache.org/jira/browse/IGNITE-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272179#comment-15272179
 ] 

Vladimir Ozerov commented on IGNITE-2805:
-----------------------------------------

Igor, my comments:

5) No need for synchronization here. Just initialize it in constructor and 
ensure acquire/release semantics on access.
7) The problem is that there are getters which actually perform some additional 
logic, e.g. isRollbackOnly. We must capture errors there as well.
9) If you know for sure that TX is closed, you should not return it. It is bad 
from security perspective because you return some garbage to user. Instead, 
depending on the interface, you should either return NULL or some dummy invalid 
transaction.

> CPP: Implement transactions API for CPP client.
> -----------------------------------------------
>
>                 Key: IGNITE-2805
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2805
>             Project: Ignite
>          Issue Type: Task
>          Components: platforms
>    Affects Versions: 1.5.0.final
>            Reporter: Igor Sapego
>            Assignee: Igor Sapego
>             Fix For: 1.6
>
>
> We should implement Transactions API for Ignite C++.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to