[ 
https://issues.apache.org/jira/browse/IGNITE-14913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454657#comment-17454657
 ] 

Ilya Shishkov edited comment on IGNITE-14913 at 5/26/22 4:42 PM:
-----------------------------------------------------------------

It seems, that command with the proposed syntax (with regex) can result to the 
unpredictable results for an user.
I think, that 2 main use cases are to turn on/off or show status of metrics:
 # For all caches of a cluster.
 # For a particular list of the caches.

IMHO, below syntax is more suitable:
{code:java}
--cache metrics enable|disable|status --caches cache1[,...,cacheN]|--all-caches
{code}


was (Author: shishkovilja):
It seems, that command with the proposed syntax (with regex) can result to the 
unpredictable results for an user.
I think, that 2 main use cases are to turn on/off or show status of metrics:
#  For all caches of a cluster.
#  For a particular list of the caches.

IMHO, below syntax is more suitable:
{code}
--cache metric enable|disable|status --caches cache1[,...,cacheN]|--all-caches
{code}

> Add cache statistics switch to control script
> ---------------------------------------------
>
>                 Key: IGNITE-14913
>                 URL: https://issues.apache.org/jira/browse/IGNITE-14913
>             Project: Ignite
>          Issue Type: New Feature
>          Components: control.sh
>            Reporter: Ilya Shishkov
>            Assignee: Ilya Shishkov
>            Priority: Minor
>              Labels: ise
>             Fix For: 2.14
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently, enabling or disabling cache metrics collection is available only 
> via IgniteVisorCmd or JMX. Because it seems that IgniteVisorCmd is no longer 
> being developed, it would be helpful to add a command to manage cache metrics 
> collection.
> Suggested syntax for a command:
> {code:java}
> --cache metrics enable|disable|status --caches 
> cache1[,...,cacheN]|--all-caches
>   Manages user cache metrics collection: enables, disables it or shows status.
>   Parameters:
>     --caches cache1[,...,cacheN]  - specifies a comma-separated list of cache 
> names to which sub-command should be applied.
>     --all-caches                  - applies sub-command to all user caches.
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to