[ 
https://issues.apache.org/jira/browse/IGNITE-17377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567155#comment-17567155
 ] 

Andrey Mashenkov commented on IGNITE-17377:
-------------------------------------------

[~korlov],  LGTM
would you please add a short comment to the added code on why we need to clean 
Commons#implicitPkEnabled ? and proceed merging.

> Sql. Reset implicitPkEnabled before and after all tests
> -------------------------------------------------------
>
>                 Key: IGNITE-17377
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17377
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>            Reporter: Konstantin Orlov
>            Assignee: Konstantin Orlov
>            Priority: Major
>              Labels: ignite-3
>             Fix For: 3.0.0-alpha6
>
>
> {{ItSqlLogicTest}} takes an advantage of internal "key-less tables" feature, 
> which is toggled by {{Commons#implicitPkEnabled}}. This flag is cached, so we 
> need to reset it before the very first test from this suite will be executed, 
> because just provide the system prop is not enough. Also we need to reset 
> this flag one more time after all tests have passed to not affect the tests 
> from other suits.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to