[
https://issues.apache.org/jira/browse/IGNITE-17469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Pochatkin updated IGNITE-17469:
---------------------------------------
Description:
cli config profile now has two commands show and create, while setting a
profile is done through a parameter, which is confusing.
There should be a separate command to set the profile.
In general I would suggest the commands there to look like:
cli config show
cli config set
cli config get
All repl cli commands should not accept --profile or -p parameters, all setting
and getting of the params in a profile should go through its activation
instead. I.e. cli config profile create newprofile ; cli config profile
activate newprofile; cli config set
ignite.cluster-url=[http://localhost:10300|http://localhost:10300/]
We should retain --profile in non-repl mode.
Profile manipulation should go like below:
cli config profile show [<name>]
cli config profile list
cli config profile create <name> --copy-from
cli config profile activate <name>
Let’s please update IEP with the corresponding changes as well.
Let's also make sure non-repl commands do have --profile option and
auto-completion scripts are updated accordingly. Currently I don't see any
suggestions on --profile there:
{noformat}
tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$ ./ignite cluster config show
--profile te
st
Unknown options: '--profile', 'test'
Usage: ignite cluster config show [-h] [--cluster-url=<clusterUrl>]
[--selector=<selector>]
Shows cluster configuration.
--cluster-url=<clusterUrl>
Url to ignite node.
-h, --help Show this help message and exit.
--selector=<selector>
Configuration path selector.
tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$
{noformat}
was:
cli config profile now has two commands show and create, while setting a
profile is done through a parameter, which is confusing.
There should be a separate command to set the profile.
In general I would suggest the commands there to look like:
cli config show
cli config set
cli config get
All repl cli commands should not accept --profile or -p parameters, all setting
and getting of the params in a profile should go through its activation
instead. I.e. cli config profile create newprofile ; cli config profile
activate newprofile; cli config set
ignite.cluster-url=[http://localhost:10300|http://localhost:10300/]
We should retain --profile in non-repl mode.
Profile manipulation should go like below:
cli config profile show [<name>]
cli config profile list
cli config profile create <name> --copy-from
cli config profile activate <name>
Let’s please update IEP with the corresponding changes as well.
Let's also make sure non-cli commands do have --profile option and
auto-completion scripts are updated accordingly. Currently I don't see any
suggestions on --profile there:
{noformat}
tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$ ./ignite cluster config show
--profile te
st
Unknown options: '--profile', 'test'
Usage: ignite cluster config show [-h] [--cluster-url=<clusterUrl>]
[--selector=<selector>]
Shows cluster configuration.
--cluster-url=<clusterUrl>
Url to ignite node.
-h, --help Show this help message and exit.
--selector=<selector>
Configuration path selector.
tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$
{noformat}
> cli profile commands unification
> --------------------------------
>
> Key: IGNITE-17469
> URL: https://issues.apache.org/jira/browse/IGNITE-17469
> Project: Ignite
> Issue Type: Improvement
> Components: cli, ignite-3
> Reporter: Yury Yudin
> Assignee: Vadim Pakhnushev
> Priority: Major
> Labels: ignite-3
>
> cli config profile now has two commands show and create, while setting a
> profile is done through a parameter, which is confusing.
> There should be a separate command to set the profile.
> In general I would suggest the commands there to look like:
> cli config show
> cli config set
> cli config get
> All repl cli commands should not accept --profile or -p parameters, all
> setting and getting of the params in a profile should go through its
> activation instead. I.e. cli config profile create newprofile ; cli config
> profile activate newprofile; cli config set
> ignite.cluster-url=[http://localhost:10300|http://localhost:10300/]
> We should retain --profile in non-repl mode.
> Profile manipulation should go like below:
> cli config profile show [<name>]
> cli config profile list
> cli config profile create <name> --copy-from
> cli config profile activate <name>
>
> Let’s please update IEP with the corresponding changes as well.
>
> Let's also make sure non-repl commands do have --profile option and
> auto-completion scripts are updated accordingly. Currently I don't see any
> suggestions on --profile there:
> {noformat}
> tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$ ./ignite cluster config
> show --profile te
> st
> Unknown options: '--profile', 'test'
> Usage: ignite cluster config show [-h] [--cluster-url=<clusterUrl>]
> [--selector=<selector>]
> Shows cluster configuration.
> --cluster-url=<clusterUrl>
> Url to ignite node.
> -h, --help Show this help message and exit.
> --selector=<selector>
> Configuration path selector.
> tests@ubuntu:~/Work/apache-ignite-3.0.0-SNAPSHOT$
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
