[ 
https://issues.apache.org/jira/browse/IGNITE-17783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611579#comment-17611579
 ] 

Roman Puchkovskiy commented on IGNITE-17783:
--------------------------------------------

The patch looks good to me

> Size metrics improvement part 2
> -------------------------------
>
>                 Key: IGNITE-17783
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17783
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Aleksandr Polovtcev
>            Assignee: Aleksandr Polovtcev
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When implementing IGNITE-17728, PagesFillFactor metrics was interpreted 
> incorrectly. It was assumed (mostly due to non-existent javadoc) that it 
> should reflect the ratio of occupied space to the total allocated space. It 
> turns out that it is actually used to understand if a lot of pages are not 
> filled completely (which may indicate an unsuitable cache entry size, for 
> example), so it should be computed as a ratio of total occupied space (page 
> data without fragmentation) to the space of all non-empty pages.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to