Anton Vinogradov created IGNITE-17851:
-----------------------------------------

             Summary: TX cache update counter must deny already closed gaps 
re-closing instead of returning false
                 Key: IGNITE-17851
                 URL: https://issues.apache.org/jira/browse/IGNITE-17851
             Project: Ignite
          Issue Type: Sub-task
            Reporter: Anton Vinogradov


Currently {{PartitionUpdateCounterTrackingImpl#update()}} just returns false 
when closing already closed gap.
Such behaviour allows to reuse the same counter and may lead to the hidden 
inconsistency.
It should be refactored to provide only-once closing guarantee.

According to the PR (I have checked the change at the TeamCity) none tests 
fails on a explicit assertion added to the 
{{IgniteTxHandler#applyPartitionsUpdatesCounters()}} which checks that 
PartitionUpdateCounterTrackingImpl#update() never returns the false.
So, all we need it so refactor the method to avoid "false" returning.

BTW, it looks like after the refactoring we able to get rid of boolean return 
at {{PartitionUpdateCounter#update()}} at all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to