[ 
https://issues.apache.org/jira/browse/IGNITE-17895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617561#comment-17617561
 ] 

Ignite TC Bot commented on IGNITE-17895:
----------------------------------------

{panel:title=Branch: [pull/10313/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/10313/head] Base: [master] : New Tests 
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Basic 4{color} [[tests 
1|https://ci2.ignite.apache.org/viewLog.html?buildId=6817072]]
* {color:#013220}IgniteBasicTestSuite2: 
PeriodicHistogramMetricImplTest.testCurrentTimeDecreasing - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=6817179&buildTypeId=IgniteTests24Java8_RunAll]

> Assertion on histogram update if currentTimeMillis decreases
> ------------------------------------------------------------
>
>                 Key: IGNITE-17895
>                 URL: https://issues.apache.org/jira/browse/IGNITE-17895
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Aleksey Plekhanov
>            Assignee: Aleksey Plekhanov
>            Priority: Major
>              Labels: ise
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Histogram metric classes (\{{HistogramMetricImpl}}, 
> \{{PeriodicHistogramMetricImpl}}) assume that timestamp is always increasing, 
> but in some cases method {{U.currentTimeMillis()}} can return decreasing 
> values (for example, if time was set manually or on NTP sync). In these cases 
> assertion can be thrown on histogram update:
> {noformat}
> java.lang.AssertionError: null
> at 
> org.apache.ignite.internal.processors.metric.impl.HistogramMetricImpl.value(HistogramMetricImpl.java:61)
>  ~[classes/:?]
> at 
> org.apache.ignite.internal.util.StripedExecutor$Stripe.body(StripedExecutor.java:643)
>  [classes/:?]
> at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:125) 
> [classes/:?]
> at java.lang.Thread.run(Thread.java:750) [?:1.8.0_322]{noformat}
> We should fix {{PeriodicHistogramMetricImpl#add}} and 
> {{HistogramMetricImpl#value}} methods to work correctly with decreasing 
> timestamps.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to