[
https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304325#comment-15304325
]
Semen Boikov commented on IGNITE-2969:
--------------------------------------
Did quick review, have some comments:
- you added additional 'sychronized' usages, need check that it does not impact
performance, please execute some single-node benchmark. If performance is
impacted then need to use additional synchronization only if timeout is enabled
- in some places there is nested synchronization, I think it can be changed to
use only one mutex
- now transactions implement GridTimeoutObject and 'isTimedOut' is called in
some random places, I think this complicates timeout handling logic and is not
really needed. Let's remove GridTimeoutObject from tx, and all timeout handling
logic should remain only in transaction futures (lock and prepare futures)
> Optimistic transactions support in deadlock detection
> -----------------------------------------------------
>
> Key: IGNITE-2969
> URL: https://issues.apache.org/jira/browse/IGNITE-2969
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Reporter: Andrey Gura
> Assignee: Andrey Gura
> Fix For: 1.7
>
>
> Deadlock detection doesn't support optimistic transactions now. It should be
> implemented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
