[ 
https://issues.apache.org/jira/browse/IGNITE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Tupitsyn updated IGNITE-18766:
------------------------------------
    Description: 
ClusterGroup.forNodeId checks *id* in a loop instead of *id0*:

{code:java}
                for (UUID id0 : ids) {
                    if (contains(id))
                        nodeIds.add(id0);
                }
{code}

https://github.com/apache/ignite/blob/3de1dc44f53ea510328badf6cb6b423fe6975bd8/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java#L461

The following unit test demonstrates the problem:


{code:java}
    @Test
    public void testProjectionWithBadId() {
        ClusterNode locNode = ignite.cluster().localNode();

        ClusterGroup prj = ignite.cluster().forNodeId(UUID.randomUUID(), 
locNode.id());
        Collection<ClusterNode> nodes = prj.nodes();

        assertEquals(1, nodes.size());
    }
{code}

(add to GridProjectionForCachesSelfTest)

  was:
ClusterGroup.forNodeId checks *id* in a loop instead of *id0*:

{code:java}
                for (UUID id0 : ids) {
                    if (contains(id))
                        nodeIds.add(id0);
                }
{code}

https://github.com/apache/ignite/blob/3de1dc44f53ea510328badf6cb6b423fe6975bd8/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java#L461

The following unit test demonstrates the problem:


> Incorrect id check in ClusterGroupAdapter.forNodeId
> ---------------------------------------------------
>
>                 Key: IGNITE-18766
>                 URL: https://issues.apache.org/jira/browse/IGNITE-18766
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.14
>            Reporter: Pavel Tupitsyn
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.15
>
>
> ClusterGroup.forNodeId checks *id* in a loop instead of *id0*:
> {code:java}
>                 for (UUID id0 : ids) {
>                     if (contains(id))
>                         nodeIds.add(id0);
>                 }
> {code}
> https://github.com/apache/ignite/blob/3de1dc44f53ea510328badf6cb6b423fe6975bd8/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java#L461
> The following unit test demonstrates the problem:
> {code:java}
>     @Test
>     public void testProjectionWithBadId() {
>         ClusterNode locNode = ignite.cluster().localNode();
>         ClusterGroup prj = ignite.cluster().forNodeId(UUID.randomUUID(), 
> locNode.id());
>         Collection<ClusterNode> nodes = prj.nodes();
>         assertEquals(1, nodes.size());
>     }
> {code}
> (add to GridProjectionForCachesSelfTest)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to