[
https://issues.apache.org/jira/browse/IGNITE-18564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Uttsel updated IGNITE-18564:
-----------------------------------
Description:
h3. Motivation
DistributionZoneManagerWatchListenerTest checks only default zone. Now when
individual zone change trigger were created it is possible to test custom zones
too. So need to add a custom zone to all tests in
DistributionZoneManagerWatchListenerTest.
DistributionZoneManager has a watch listener which is triggered on update
"distributionZones.logicalTopology" key and updates zone dataNodes in the
metastorage. Also DistributionZoneManager has a method
initDataNodesFromVaultManager() which save zone dataNodes on
DistributionZoneManager#start(). DistributionZoneManagerWatchListenerTest
checks this logic. But it checks only for default zone. Now when individual
zone change trigger keys were created it is possible to test custom zones too.
So need to add a custom zone to all tests in
DistributionZoneManagerWatchListenerTest.
# testDataNodesOfDefaultZoneUpdatedOnWatchListenerEvent - the test checks that
dataNodes is updated on watch event. Need to add custom zone and check it.
# testStaleWatchEvent - the test checks that dataNodes is not updated on stale
watch event. Need to add custom zone and check it.
# testStaleVaultRevisionOnZoneManagerStart - the test checks that dataNodes is
not updated from the vault on DistributionZoneManager#start() if the vault
applied revision is stale. Need to add custom zone and check it.
# testDataNodesUpdatedOnZoneManagerStart - the test checks that dataNodes is
updated from the vault on DistributionZoneManager#start(). Need to add custom
zone and check it.
# testLogicalTopologyIsNullOnZoneManagerStart - the test checks that dataNodes
is not updated from the vault on DistributionZoneManager#start() if
"distributionZones.logicalTopology" is null in the vault. Need to add custom
zone and check it.
*Definition of Done*
Tests in the DistributionZoneManagerWatchListenerTest check not only default
zone, but also a custom zone.
was:
h3. Motivation
DistributionZoneManagerWatchListenerTest checks only default zone. Now when
individual zone change trigger were created it is possible to test custom zones
too. So need to add a custom zone to all tests in
DistributionZoneManagerWatchListenerTest.
*Definition of Done*
Tests in the DistributionZoneManagerWatchListenerTest check not only default
zone, but also a custom zone.
> Extend test coverage for WatchListener in DistributionZoneManager
> -----------------------------------------------------------------
>
> Key: IGNITE-18564
> URL: https://issues.apache.org/jira/browse/IGNITE-18564
> Project: Ignite
> Issue Type: Bug
> Reporter: Sergey Uttsel
> Assignee: Sergey Uttsel
> Priority: Major
> Labels: ignite-3
>
> h3. Motivation
> DistributionZoneManagerWatchListenerTest checks only default zone. Now when
> individual zone change trigger were created it is possible to test custom
> zones too. So need to add a custom zone to all tests in
> DistributionZoneManagerWatchListenerTest.
> DistributionZoneManager has a watch listener which is triggered on update
> "distributionZones.logicalTopology" key and updates zone dataNodes in the
> metastorage. Also DistributionZoneManager has a method
> initDataNodesFromVaultManager() which save zone dataNodes on
> DistributionZoneManager#start(). DistributionZoneManagerWatchListenerTest
> checks this logic. But it checks only for default zone. Now when individual
> zone change trigger keys were created it is possible to test custom zones
> too. So need to add a custom zone to all tests in
> DistributionZoneManagerWatchListenerTest.
> # testDataNodesOfDefaultZoneUpdatedOnWatchListenerEvent - the test checks
> that dataNodes is updated on watch event. Need to add custom zone and check
> it.
> # testStaleWatchEvent - the test checks that dataNodes is not updated on
> stale watch event. Need to add custom zone and check it.
> # testStaleVaultRevisionOnZoneManagerStart - the test checks that dataNodes
> is not updated from the vault on DistributionZoneManager#start() if the vault
> applied revision is stale. Need to add custom zone and check it.
> # testDataNodesUpdatedOnZoneManagerStart - the test checks that dataNodes is
> updated from the vault on DistributionZoneManager#start(). Need to add custom
> zone and check it.
> # testLogicalTopologyIsNullOnZoneManagerStart - the test checks that
> dataNodes is not updated from the vault on DistributionZoneManager#start() if
> "distributionZones.logicalTopology" is null in the vault. Need to add custom
> zone and check it.
> *Definition of Done*
> Tests in the DistributionZoneManagerWatchListenerTest check not only default
> zone, but also a custom zone.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
