[ 
https://issues.apache.org/jira/browse/IGNITE-19358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maksim Zhuravkov updated IGNITE-19358:
--------------------------------------
    Description: 
PrepareService prepareDml cache does not take dynamic parameters into account 
which may potentially lead to runtime errors when different queries reuse the 
same plan.

{code:java}
    private CompletableFuture<QueryPlan> prepareDml(SqlNode sqlNode, 
PlanningContext ctx) {
        var key = new CacheKey(ctx.schemaName(), sqlNode.toString());
        ....
{code}

Expected behaviour: dml plan cache should take dynamic parameters/types of 
dynamic parameters into account.




  was:
PrepareService prepareDml cache does not take dynamic parameters into account 
which may leads to runtime errors when different queries reuse the same plan:

{code:java}
 @Test
    public void test() {
        sql("SELECT ? + 1", 1);
        sql("SELECT ? + 1", 'X');
    }
{code}

Error:

{code:java}
IGN-CMN-65535 TraceId:028c3d10-1840-4fa4-bad2-d1ed8498654a class 
java.lang.Character cannot be cast to class java.lang.Integer 
(java.lang.Character and java.lang.Integer are in module java.base of loader 
'bootstrap')
org.apache.ignite.lang.IgniteException: IGN-CMN-65535 
TraceId:028c3d10-1840-4fa4-bad2-d1ed8498654a class java.lang.Character cannot 
be cast to class java.lang.Integer (java.lang.Character and java.lang.Integer 
are in module java.base of loader 'bootstrap')
{code}

Expected behaviour: dml plan cache should take dynamic parameters/types of 
dynamic parameters into account.





> Sql. PrepareServiceImpl prepareDML cache does not take dynamic parameters 
> into account
> --------------------------------------------------------------------------------------
>
>                 Key: IGNITE-19358
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19358
>             Project: Ignite
>          Issue Type: Bug
>          Components: sql
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Maksim Zhuravkov
>            Priority: Major
>              Labels: calcite3-required, ignite-3
>
> PrepareService prepareDml cache does not take dynamic parameters into account 
> which may potentially lead to runtime errors when different queries reuse the 
> same plan.
> {code:java}
>     private CompletableFuture<QueryPlan> prepareDml(SqlNode sqlNode, 
> PlanningContext ctx) {
>         var key = new CacheKey(ctx.schemaName(), sqlNode.toString());
>         ....
> {code}
> Expected behaviour: dml plan cache should take dynamic parameters/types of 
> dynamic parameters into account.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to