[
https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331747#comment-15331747
]
Semen Boikov commented on IGNITE-2969:
--------------------------------------
Reviewed, my comments:
- need change GridNearOptimisticTxPrepareFuture.requestedKeys to do not convert
IgniteTxKey into KeyCacheObject (also fix this for
GridDhtColocatedLockFuture.requestedKeys)
- need add synhronization for 'futs' access in
GridNearOptimisticTxPrepareFuture.requestedKeys
- in GridNearOptimisticTxPrepareFuture you check that future timedout only at
the moment when next MiniFuture is completed, I think this makes unnecessary
GridNearOptimisticTxPrepareFuture.timeoutObj, just check remaining time at the
moment when MiniFuture is completed. Also notice that currently there is a bug:
GridNearOptimisticTxPrepareFuture:497 - you call remainingTime, but do not
check it for '-1'.
- it is potentially dangerous that in GridDhtTxPrepareFuture too many code is
executed inside 'sychronized' block. Please try to change it (e.g. from
onTimeout callback clean 'lockKeys' and 'futs', thus message responses and
onOwnerChanged callback will be ignored). Also let's avoid
synchronzied(lockKeys) inside synchronzied(this)
- please add deadlock detection futures logging in
GridCachePartitionExchangeManager.dumpDebugInfo
- I noticed that when I run TxDeadlockDetectionNoHangsTest then deadlock
detection future was finished by timeout, let's increase this timeout in tests
to detect such cases
- please add similar NoHangs test with deadlock detection disabled
- please add deadlock detection test with cross cache tx
> Optimistic transactions support in deadlock detection
> -----------------------------------------------------
>
> Key: IGNITE-2969
> URL: https://issues.apache.org/jira/browse/IGNITE-2969
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Reporter: Andrey Gura
> Assignee: Andrey Gura
> Fix For: 1.7
>
>
> Deadlock detection doesn't support optimistic transactions now. It should be
> implemented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
