[ 
https://issues.apache.org/jira/browse/IGNITE-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331912#comment-15331912
 ] 

Alexey Kuznetsov commented on IGNITE-3293:
------------------------------------------

Igor, I do some review on your AWS bootstrap scripts.

Very impressive amount of work was done, but from my point of view we need to 
fix following issues:
1) Please write some REDAME.txt or DEVNOTES.txt in 
"modules/cassandra/src/test/bootstrap/aws" that will describe how this all 
should be used.
Ideally one should take this step-by-step instruction and be able to run tests 
on AWS.

2) Please add more comments in all *.sh files some of them are quite well 
commented, some of them has no comments at all.

3) Take a look at cassandra-bootstrap.sh and please make configurable setting 
like this:
   AWS_CLI_DOWNLOAD_URL=https://s3.amazonaws.com/aws-cli/awscli-bundle.zip
   
JDK_DOWNLOAD_URL=http://download.oracle.com/otn-pub/java/jdk/8u77-b03/jdk-8u77-linux-x64.tar.gz
   
TESTS_PACKAGE_DONLOAD_URL=s3://bucket/folder/ignite-cassandra-tests-1.6.0-SNAPSHOT.zip
Please look for all such places. By the way, why 
"ignite-cassandra-tests-1.6.0-SNAPSHOT.zip" ?

4) Also I found hardcoded IP addresses like : http://169.254.169.254 in 
"modules/cassandra/src/test/bootstrap/aws/common.sh"
  It is OK to have such addresses? I think they also should be configurable.

> AWS bootstrap scripts patch for Ignite-Cassandra 
> -------------------------------------------------
>
>                 Key: IGNITE-3293
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3293
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 1.6, 1.7
>            Reporter: Igor Rudyak
>            Assignee: Igor Rudyak
>
> New version of AWS bootstrap script having:
> 1) Gaglia monitoring
> 2) Allows to manually trigger tests execution multiple times on the same 
> ifstastructure



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to