[
https://issues.apache.org/jira/browse/IGNITE-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333681#comment-15333681
]
ASF GitHub Bot commented on IGNITE-3139:
----------------------------------------
GitHub user ptupitsyn opened a pull request:
https://github.com/apache/ignite/pull/809
IGNITE-3139 .NET: UTF-16 surrogate symbols are not serialized properly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ptupitsyn/ignite ignite-3139
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/809.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #809
----
commit 74c051230b906897babbcb6553af60e2af1b44a0
Author: Aleksei Scherbakov <[email protected]>
Date: 2016-05-12T12:47:01Z
IGNITE-3098: UTF-16 surrogate pairs are not properly serialized by
BinaryMarshaller
commit 76717fd348a51ae597cb2bc99b9672994dde3264
Author: Denis Magda <[email protected]>
Date: 2016-05-13T05:24:37Z
IGNITE-3098: compilation fix
commit 99b8830e3af4a9dd596374fc21e5fb6d79ada083
Author: Denis Magda <[email protected]>
Date: 2016-05-13T05:40:02Z
Merge remote-tracking branch 'remotes/origin/ignite-1.6' into ignite-3098
commit d43b71c526d2ee0ac8a40bb52bbdbbaa8c595f13
Author: Denis Magda <[email protected]>
Date: 2016-05-16T08:08:11Z
IGNITE-3098: improvements
commit 9e167073fd51b78870b8f62e867518b1f540a080
Author: Denis Magda <[email protected]>
Date: 2016-05-16T08:11:10Z
Merge remote-tracking branch 'remotes/origin/ignite-1.6' into ignite-3098
commit 9c7824829da5f6994f4c302cc39f03ac897d6616
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T09:16:59Z
IGNITE-3139 .Net: UTF-16 surrogate symbols are not serialized properly
commit d466a081249670feff843514453de85443b86251
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T09:18:10Z
test added
commit 3c4e122d5e8c41d5ca051dd82e95e191bcd3dc9a
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T09:29:13Z
wip
commit fa48e3dd6df615465c2447b5efa7ce9efdabdde5
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T09:36:10Z
Refactor string writes
commit 4196e1ff0fd3536027add755ad51b796afc47d79
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T09:55:54Z
wip
commit 42d892816507280d3a5897210221591bc88f6430
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:00:28Z
wip
commit d1d52b3940bb122778783bbbb3360c8acb788763
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:08:58Z
wip
commit 3f9326e9824f1c6573ac02d372645185de685d8b
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:13:24Z
wip
commit da494d0a43284ca2d6d2594f7d58145c017e05f7
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:44:40Z
wip
commit 91d079a4b1625ec70c1159656bd2a0839f815b93
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:49:19Z
Fix length calculation - tests work
commit e6980ac51a886dae54be9a5e1f0e61893d310360
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:53:13Z
wip
commit d879325317bcfee02aca5d72bea23c69bcd74899
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T10:56:37Z
wip
commit 162a1bedd9b89c3b3e40acc456aa7a79e8a64771
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T11:12:20Z
wip cleanup
commit cbb7ecb323b3e87432c74e082f92a30531c9c7fb
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T11:14:09Z
wip tests
commit f606c71466f388aed1cdaf407ec278f5f0cf21eb
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T11:23:26Z
wip
commit d6abe080978eea34b6067971ca557453a245c6dc
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T11:26:23Z
wip
commit 0dc1f9d1343c4bee96f28b2223723ebaa4a4a3d1
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T11:54:19Z
wip
commit 5d1960cca587efd8a1cce72a75404d5c9bd39dab
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T12:21:23Z
wip
commit af3d2ebfe28d1263240ba4b342cbc15dab3a2565
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T12:26:01Z
wip
commit d97813a72cd6ba7607b1feb387b546ccfd00a117
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T12:33:40Z
wip
commit efc80b43b7cc69ed17cbc225adb654299634ea1b
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T12:55:49Z
wip
commit 5ff788dbe3b6c5bb1559fb261d3141bdfb904ebf
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T13:08:14Z
Finally, test works, damn it
commit 2439812546ea14f5a191881b5c59ccaed4af123a
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T13:11:42Z
Check special strings with Java
commit 53999e33c771caad5cfccad386f62dcea6af53a4
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T13:13:44Z
wip
commit 1407152178c29e43efbb382d585f4d80fd5df264
Author: Pavel Tupitsyn <[email protected]>
Date: 2016-05-16T13:30:09Z
failure test added
----
> .NET: UTF-16 surrogate symbols are not serialized properly
> ----------------------------------------------------------
>
> Key: IGNITE-3139
> URL: https://issues.apache.org/jira/browse/IGNITE-3139
> Project: Ignite
> Issue Type: Bug
> Components: platforms
> Affects Versions: 1.5.0.final
> Reporter: Denis Magda
> Assignee: Pavel Tupitsyn
> Fix For: 1.7
>
>
> There is an issue with serialization of a surrogate symbol with
> {{BinaryMarshaller}}. On Java side String's serialization logic was improved
> to support all the cases. Refer to IGNITE-3098.
> .Net serialization logic has to be updated as well. Please refer to the
> algorithm located in ignite-3098 branch in the following places:
> - {{BinaryUtils.utf8BytesToStr}} - serialization
> - {{BinaryUtils.strToUtf8Bytes}} - deserialization
> -
> {{IgniteSystemProperties.IGNITE_BINARY_MARSHALLER_USE_STRING_SERIALIZATION_VER_2}}
> controls which version of serialization logic to use (old or new).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
