[
https://issues.apache.org/jira/browse/IGNITE-19457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730130#comment-17730130
]
Alexander Lapin commented on IGNITE-19457:
------------------------------------------
[~v.pyatkov] LGTM, Thanks!
> Review nullability of network messages' fields
> ----------------------------------------------
>
> Key: IGNITE-19457
> URL: https://issues.apache.org/jira/browse/IGNITE-19457
> Project: Ignite
> Issue Type: Improvement
> Reporter: Semyon Danilov
> Assignee: Vladislav Pyatkov
> Priority: Major
> Labels: ignite-3
> Time Spent: 20m
> Remaining Estimate: 0h
>
> h3. Motivation
> After implementing https://issues.apache.org/jira/browse/IGNITE-19437
> occurred that following list of fields in messages are null despite the fact
> that probably they should be @NotNull, probably that means that we've forgot
> to add corresponding setters while building such methods.
> * PlacementDriverMessage, ReplicaRequest:
> {code:java}
> groupId{code}
> * SnapshotRequestMessage:
> {code:java}
> id{code}
> * ReadWriteMultiRowReplicaRequest:
> {code:java}
> commitPartitionId{code}
> * ReadWriteReplicaRequest:
> {code:java}
> transactionId{code}
> * ReadWriteSingleRowReplicaRequest:
> {code:java}
> commitPartitionId{code}
> h3. Definition of Done
> * For each case null-ability verified and either comment is written
> explaining why it's valid to have null value or setter is added and
> @Nullable is removed.
> * Tests not needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
