[ 
https://issues.apache.org/jira/browse/IGNITE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348191#comment-15348191
 ] 

ASF GitHub Bot commented on IGNITE-3140:
----------------------------------------

GitHub user isapego opened a pull request:

    https://github.com/apache/ignite/pull/829

    IGNITE-3140: Added tests for string format validity.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/isapego/ignite ignite-3140

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/829.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #829
    
----
commit 9ca608aa8cf91d546dfa08dd7f560d42047b1c3d
Author: isapego <[email protected]>
Date:   2016-06-23T16:53:32Z

    IGNITE-3140: Added tests for string format validity.

commit 41e8d703d45b532c0169f523672fe7ab5291bb87
Author: isapego <[email protected]>
Date:   2016-06-23T17:00:55Z

    IGNTIE-3140: Minor fix for test.

commit f70ef622cb05159da99786697a533260bae57929
Author: isapego <[email protected]>
Date:   2016-06-24T12:14:25Z

    IGNITE-3140: Fix for JVM reloading.

----


> C++: UTF-16 surrogate symbols are not serialized properly
> ---------------------------------------------------------
>
>                 Key: IGNITE-3140
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3140
>             Project: Ignite
>          Issue Type: Bug
>          Components: platforms
>    Affects Versions: 1.5.0.final
>            Reporter: Denis Magda
>            Assignee: Igor Sapego
>             Fix For: 1.7
>
>
> There is an issue with serialization of a surrogate symbol with 
> {{BinaryMarshaller}}. On Java side String's serialization logic was improved 
> to support all the cases. Refer to IGNITE-3098.
> C++ serialization logic has to be updated as well. Please refer to the 
> algorithm located in ignite-3098 branch in the following places:
> - {{BinaryUtils.utf8BytesToStr}} - serialization
> - {{BinaryUtils.strToUtf8Bytes}} - deserialization
> - 
> {{IgniteSystemProperties.IGNITE_BINARY_MARSHALLER_USE_STRING_SERIALIZATION_VER_2}}
>  controls which version of serialization logic to use (old or new).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to