[ 
https://issues.apache.org/jira/browse/IGNITE-20058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Uttsel updated IGNITE-20058:
-----------------------------------
    Description: 
*{{Motivation}}*

{{DistributionZoneManagerAlterFilterTest.testAlterFilter}} is flaky and with 
very low failure rate it fails with NPE (1 fail in 1500 runs)
{noformat}
2023-07-25 16:48:30:520 +0400 
[ERROR][%test%metastorage-watch-executor-0][WatchProcessor] Error occurred when 
processing a watch event
java.lang.NullPointerException
        at 
org.apache.ignite.internal.distributionzones.DistributionZoneManager.lambda$onUpdateScaleDown$18(DistributionZoneManager.java:737)
        at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier.notifyPublicListeners(ConfigurationNotifier.java:488)
        at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:136)
        at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:129)
        at 
org.apache.ignite.internal.distributionzones.configuration.DistributionZoneNode.traverseChildren(Unknown
 Source)
{noformat}
{code:java}
2023-08-01 15:55:40:440 +0300 
[INFO][%test%metastorage-watch-executor-1][ConfigurationRegistry] Failed to 
notify configuration listener
java.lang.NullPointerException
    at 
org.apache.ignite.internal.distributionzones.causalitydatanodes.CausalityDataNodesEngine.updateZoneConfiguration(CausalityDataNodesEngine.java:570)
    at 
org.apache.ignite.internal.distributionzones.causalitydatanodes.CausalityDataNodesEngine.onUpdateFilter(CausalityDataNodesEngine.java:557)
    at 
org.apache.ignite.internal.distributionzones.DistributionZoneManager.lambda$onUpdateFilter$18(DistributionZoneManager.java:774)
    at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier.notifyPublicListeners(ConfigurationNotifier.java:488)
    at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:136)
    at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:129)
    at 
org.apache.ignite.internal.distributionzones.configuration.DistributionZoneNode.traverseChildren(Unknown
 Source){code}
 
*Implementation Notes*
The reason is the wrong start order of the components:
# Firstly metastorage watch listeners are deployed.
# Then DistributionZoneManager is started.

So I change this order to fix the issue.

Also I will close https://issues.apache.org/jira/browse/IGNITE-19403  when this 
ticket will be closed.

  was:
*{{Motivation}}*

{{DistributionZoneManagerAlterFilterTest.testAlterFilter}} is flaky and with 
very low failure rate it fails with NPE (1 fail in 1500 runs)
{noformat}
2023-07-25 16:48:30:520 +0400 
[ERROR][%test%metastorage-watch-executor-0][WatchProcessor] Error occurred when 
processing a watch event
java.lang.NullPointerException
        at 
org.apache.ignite.internal.distributionzones.DistributionZoneManager.lambda$onUpdateScaleDown$18(DistributionZoneManager.java:737)
        at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier.notifyPublicListeners(ConfigurationNotifier.java:488)
        at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:136)
        at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:129)
        at 
org.apache.ignite.internal.distributionzones.configuration.DistributionZoneNode.traverseChildren(Unknown
 Source)
{noformat}
{code:java}
2023-08-01 15:55:40:440 +0300 
[INFO][%test%metastorage-watch-executor-1][ConfigurationRegistry] Failed to 
notify configuration listener
java.lang.NullPointerException
    at 
org.apache.ignite.internal.distributionzones.causalitydatanodes.CausalityDataNodesEngine.updateZoneConfiguration(CausalityDataNodesEngine.java:570)
    at 
org.apache.ignite.internal.distributionzones.causalitydatanodes.CausalityDataNodesEngine.onUpdateFilter(CausalityDataNodesEngine.java:557)
    at 
org.apache.ignite.internal.distributionzones.DistributionZoneManager.lambda$onUpdateFilter$18(DistributionZoneManager.java:774)
    at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier.notifyPublicListeners(ConfigurationNotifier.java:488)
    at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:136)
    at 
org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:129)
    at 
org.apache.ignite.internal.distributionzones.configuration.DistributionZoneNode.traverseChildren(Unknown
 Source){code}
 
*Implementation Notes*
The reason is the wrong start order of the components:
# Firstly metastorage watch listeners are deployed.
# Then DistributionZoneManager is started.
So I change this order to fix the issue.

Also I will close https://issues.apache.org/jira/browse/IGNITE-19403  when this 
ticket will be closed.


> NPE in DistributionZoneManagerAlterFilterTest#testAlterFilter
> -------------------------------------------------------------
>
>                 Key: IGNITE-20058
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20058
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Mirza Aliev
>            Assignee: Sergey Uttsel
>            Priority: Major
>              Labels: ignite-3
>
> *{{Motivation}}*
> {{DistributionZoneManagerAlterFilterTest.testAlterFilter}} is flaky and with 
> very low failure rate it fails with NPE (1 fail in 1500 runs)
> {noformat}
> 2023-07-25 16:48:30:520 +0400 
> [ERROR][%test%metastorage-watch-executor-0][WatchProcessor] Error occurred 
> when processing a watch event
> java.lang.NullPointerException
>       at 
> org.apache.ignite.internal.distributionzones.DistributionZoneManager.lambda$onUpdateScaleDown$18(DistributionZoneManager.java:737)
>       at 
> org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier.notifyPublicListeners(ConfigurationNotifier.java:488)
>       at 
> org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:136)
>       at 
> org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:129)
>       at 
> org.apache.ignite.internal.distributionzones.configuration.DistributionZoneNode.traverseChildren(Unknown
>  Source)
> {noformat}
> {code:java}
> 2023-08-01 15:55:40:440 +0300 
> [INFO][%test%metastorage-watch-executor-1][ConfigurationRegistry] Failed to 
> notify configuration listener
> java.lang.NullPointerException
>     at 
> org.apache.ignite.internal.distributionzones.causalitydatanodes.CausalityDataNodesEngine.updateZoneConfiguration(CausalityDataNodesEngine.java:570)
>     at 
> org.apache.ignite.internal.distributionzones.causalitydatanodes.CausalityDataNodesEngine.onUpdateFilter(CausalityDataNodesEngine.java:557)
>     at 
> org.apache.ignite.internal.distributionzones.DistributionZoneManager.lambda$onUpdateFilter$18(DistributionZoneManager.java:774)
>     at 
> org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier.notifyPublicListeners(ConfigurationNotifier.java:488)
>     at 
> org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:136)
>     at 
> org.apache.ignite.internal.configuration.notifications.ConfigurationNotifier$1.visitLeafNode(ConfigurationNotifier.java:129)
>     at 
> org.apache.ignite.internal.distributionzones.configuration.DistributionZoneNode.traverseChildren(Unknown
>  Source){code}
>  
> *Implementation Notes*
> The reason is the wrong start order of the components:
> # Firstly metastorage watch listeners are deployed.
> # Then DistributionZoneManager is started.
> So I change this order to fix the issue.
> Also I will close https://issues.apache.org/jira/browse/IGNITE-19403  when 
> this ticket will be closed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to