[
https://issues.apache.org/jira/browse/IGNITE-20197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756859#comment-17756859
]
Igor Sapego commented on IGNITE-20197:
--------------------------------------
Looks good to me.
> .NET: Thin 3.0: Perf: Excessive dictionary lookups by GetFieldByColumnName
> usages
> ---------------------------------------------------------------------------------
>
> Key: IGNITE-20197
> URL: https://issues.apache.org/jira/browse/IGNITE-20197
> Project: Ignite
> Issue Type: Improvement
> Components: platforms, thin client
> Affects Versions: 3.0.0-beta1
> Reporter: Pavel Tupitsyn
> Assignee: Pavel Tupitsyn
> Priority: Trivial
> Labels: .NET, ignite-3
> Fix For: 3.0.0-beta2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> All usages of
> [ReflectionUtils.GetFieldByColumnName|https://github.com/apache/ignite-3/blob/64f8248fe52a50e09eace2eea7b7308a7c8f6eaf/modules/platforms/dotnet/Apache.Ignite/Internal/Table/Serialization/ReflectionUtils.cs#L53]
> are within loops.
> As a result, *GetFieldsByColumnName(type)* is called for the same type
> multiple times.
> We should remove *ReflectionUtils.GetFieldByColumnName* to avoid this pitfall
> and perform the first lookup outside of the loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
