[ 
https://issues.apache.org/jira/browse/IGNITE-19951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757974#comment-17757974
 ] 

Evgeny Stanilovsky commented on IGNITE-19951:
---------------------------------------------

[~jooger] merged into main, thanks for your effort!

> Get rid of @NotNull annotation
> ------------------------------
>
>                 Key: IGNITE-19951
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19951
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Yury Gerzhedovich
>            Assignee: Yury Gerzhedovich
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Despite our code guide style prohibit to use {{@NotNull}}  annotation [1] we 
> have many usage of the annotation in code.
> Even more, we have example [2] with {{@NotNull}}  in code style guide. it 
> could breaks mind.
> Let's do the next:
> 1) fix example in code style guide
> 2) get rid {{@NotNull}} in code base.
> 3) add automation checksyle check to avoid appearance new usage of the 
> annotation.
> [1] [ - 
> https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2.1Commonannotatingrules|https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-2.1Commonannotatingrules]
> [2] - 
> [https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide#JavaCodeStyleGuide-4.1Allasyncmethodsshouldhaveasyncsuffix]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to