[
https://issues.apache.org/jira/browse/IGNITE-20328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761810#comment-17761810
]
Roman Puchkovskiy commented on IGNITE-20328:
--------------------------------------------
The patch looks good to me
> Cleanup in BaseIgniteAbstractTest
> ---------------------------------
>
> Key: IGNITE-20328
> URL: https://issues.apache.org/jira/browse/IGNITE-20328
> Project: Ignite
> Issue Type: Improvement
> Reporter: Aleksandr Polovtcev
> Assignee: Aleksandr Polovtcev
> Priority: Major
> Labels: ignite-3
>
> {{BaseIgniteAbstractTest}} is written in a strange way:
> # It does not utilize Junit lifecycle methods and subclasses are expected to
> manually call {{setUpBase}} and {{tearDownBase}};
> # Logger field is declared as static, but is initialized in the constructor.
> This creates a false impression that this logger can be used in static
> methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
