[ 
https://issues.apache.org/jira/browse/IGNITE-20471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mirza Aliev updated IGNITE-20471:
---------------------------------
    Description: 
*Motivation*
According the logic of invocations of {{TxManagerImpl#finish}}, it is possible 
that {{recipientNode}}, which is passed to {{finish}}, could be {{null}}. 
Further in the code of {{finish}} method we make 
{{replicaService.invoke(recipientNode)}} and this could lead to 
{{NullPointerException}}. 

UPD1: 

It is possible that I was wrong and we even don't reach the code where we call 
invoke  {{replicaService.invoke(recipientNode)}}, because before we check 
{{groups.isEmpty()}} and seems that we go through the other branch.

Need to investigate why I've got {{null}} when run 
{{ItTableRaftSnapshotsTest#entriesKeepAppendedAfterSnapshotInstallation}}

  was:
*Motivation*
According the logic of invocations of {{TxManagerImpl#finish}}, it is possible 
that {{recipientNode}}, which is passed to {{finish}}, could be {{null}}. 
Further in the code of {{finish}} method we make 
{{replicaService.invoke(recipientNode)}} and this could lead to 
{{NullPointerException}}. 

UPD1: 

It is possible that I was wrong and we even don't reach the code where we call 
invoke  {{replicaService.invoke(recipientNode)}}, because before we check 
{{groups.isEmpty()}} and seems that we go through the other branch.

Need to investigate why I've got {{null}} when run 
ItTableRaftSnapshotsTest#entriesKeepAppendedAfterSnapshotInstallation}}


> Handle TxManagerImpl#finish correctly when recipientNode is null
> ----------------------------------------------------------------
>
>                 Key: IGNITE-20471
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20471
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Mirza Aliev
>            Priority: Major
>              Labels: ignite-3
>
> *Motivation*
> According the logic of invocations of {{TxManagerImpl#finish}}, it is 
> possible that {{recipientNode}}, which is passed to {{finish}}, could be 
> {{null}}. Further in the code of {{finish}} method we make 
> {{replicaService.invoke(recipientNode)}} and this could lead to 
> {{NullPointerException}}. 
> UPD1: 
> It is possible that I was wrong and we even don't reach the code where we 
> call invoke  {{replicaService.invoke(recipientNode)}}, because before we 
> check {{groups.isEmpty()}} and seems that we go through the other branch.
> Need to investigate why I've got {{null}} when run 
> {{ItTableRaftSnapshotsTest#entriesKeepAppendedAfterSnapshotInstallation}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to