[
https://issues.apache.org/jira/browse/IGNITE-20457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774851#comment-17774851
]
Vladislav Pyatkov commented on IGNITE-20457:
--------------------------------------------
LGTM.
Just receive a green viza.
> Verify commitTimestamp against enlisted partitions expiration timestamps
> ------------------------------------------------------------------------
>
> Key: IGNITE-20457
> URL: https://issues.apache.org/jira/browse/IGNITE-20457
> Project: Ignite
> Issue Type: Bug
> Reporter: Alexander Lapin
> Assignee: Alexander Lapin
> Priority: Blocker
> Labels: ignite-3, tech-debt
> Fix For: 3.0.0-beta2
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> On tx commit It’s required to check that commit timestamp is less than
> expiration timestamps for all enlisted partitions
> h3. Implementation Notes
> * Added TxManagerImpl#verifyCommitTimestamp method that checks whether
> previously enlisted primary replicas aren't expired and that commit timestamp
> is less or equal than primary replicas expiration timestamp. Given method
> will either complete result future with void or PrimaryReplicaExpiredException
> * Added aforementioned verifyCommitTimestamp into TxManagerImpl#finish flow
> * Added PlacementDriver as an additional TxManagerImpl constructor param in
> order to retrieve current primary replicas for the futher checks in
> verifyCommitTimestamp.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
