[
https://issues.apache.org/jira/browse/IGNITE-19670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrey Mashenkov updated IGNITE-19670:
--------------------------------------
Description:
1. CatalogServiceSelftTest.testCreateTable (+testDropTable) looks a bit
complicated. It checks creation of more than one table. Let's simplify the test
by reverting last changes
2. We use shared counter to generate unique identifier for schema objects. Some
tests checks schema object id, and some doesn't. Let's move schema-object's id
check into separate test, to verify which command increments the counter, and
which doesn't.
3. Let's add a test that will check ABA problem. E.g. create-drop-create table
(or index) with same name and check the object can be resolved correctly by
name and by id (regarding object versioning in Catalog, of course).
4. Move Catalog operations tests to separate class.
was:
1. CatalogServiceSelftTest.testCreateTable (+testDropTable) looks a bit
complicated. It checks creation of more than one table. Let's simplify the test
by reverting last changes
2. We use shared counter to generate unique identifier for schema objects. Some
tests checks schema object id, and some doesn't. Let's move schema-object's id
check into separate test, to verify which command increments the counter, and
which doesn't.
3. Let's add a test that will check ABA problem. E.g. create-drop-create table
(or index) with same name and check the object can be resolved correctly by
name and by id (regarding object versioning in Catalog, of course).
> Improve CatalogService test coverage.
> -------------------------------------
>
> Key: IGNITE-19670
> URL: https://issues.apache.org/jira/browse/IGNITE-19670
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Andrey Mashenkov
> Priority: Minor
> Labels: ignite-3, tech-debt-test
>
> 1. CatalogServiceSelftTest.testCreateTable (+testDropTable) looks a bit
> complicated. It checks creation of more than one table. Let's simplify the
> test by reverting last changes
> 2. We use shared counter to generate unique identifier for schema objects.
> Some tests checks schema object id, and some doesn't. Let's move
> schema-object's id check into separate test, to verify which command
> increments the counter, and which doesn't.
> 3. Let's add a test that will check ABA problem. E.g. create-drop-create
> table (or index) with same name and check the object can be resolved
> correctly by name and by id (regarding object versioning in Catalog, of
> course).
> 4. Move Catalog operations tests to separate class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
