[
https://issues.apache.org/jira/browse/IGNITE-20855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pavel Pereslegin reassigned IGNITE-20855:
-----------------------------------------
Assignee: Pavel Pereslegin
> Sql. Rework QueryTransactionWrapper to clean up the code.
> ---------------------------------------------------------
>
> Key: IGNITE-20855
> URL: https://issues.apache.org/jira/browse/IGNITE-20855
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Pavel Pereslegin
> Assignee: Pavel Pereslegin
> Priority: Minor
> Labels: ignite-3
>
> It seems we can clean up the code if we move the code from
> {{wrapTxOrStartImplicit}} to {{QueryTransactionWrapper}}.
> Basically the proposal is:
> * add {{startTxIfNeeded(QueryType)}} non static *void* method to
> {{QueryTransactionWrapper}}, that will be responsible for starting implicit
> transaction and other checks that is now reside in static
> {{wrapTxOrStartImplicit}}.
> * rework QueryTransactionWrapper related tests
> (QueryTransactionWrapperSelfTest, JdbcQueryCursorSelfTest,
> AsyncSqlCursorImplTest)
> This will reduce the amount and complexity of code in SqlQueryProcessor (In
> particular when processing a multi-statements query).
> The task was created based on a comment
> https://github.com/apache/ignite-3/pull/2789#discussion_r1392475145
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
