[ 
https://issues.apache.org/jira/browse/IGNITE-21202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladislav Pyatkov updated IGNITE-21202:
---------------------------------------
    Description: 
h3. Motivation
Recently, we changed the process of granting leases. This process uses the node 
ID as a leaseholder identifier. The other components should also follow this 
consistently.

h3. Definition of done
# Here we are using the deprecated property, but we should use the leasholder 
ID.
{code}
String leaseholderName = 
topologyService.getById(primaryReplicaEvent.leaseholderId()).name();

updatePrimaryReplica(tablePartitionId, primaryReplicaEvent.startTime(), 
leaseholderName);
{code}
# The lesholder property should be removed from the event parameters.

  was:
h3. Motivation
Recently, we changed the process of granting leases. This process uses the node 
ID as a leaseholder identifier. The other components should also follow this 
consistently.

h3. Definition of done
Here we resolve a node name by the node ID, but we should use the ID as is.
{code}
String leaseholderName = 
topologyService.getById(primaryReplicaEvent.leaseholderId()).name();

updatePrimaryReplica(tablePartitionId, primaryReplicaEvent.startTime(), 
leaseholderName);
{code}


> Use node ID instead of node name to identify primary node in client primary 
> replica tracker
> -------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-21202
>                 URL: https://issues.apache.org/jira/browse/IGNITE-21202
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vladislav Pyatkov
>            Priority: Major
>              Labels: ignite-3
>
> h3. Motivation
> Recently, we changed the process of granting leases. This process uses the 
> node ID as a leaseholder identifier. The other components should also follow 
> this consistently.
> h3. Definition of done
> # Here we are using the deprecated property, but we should use the leasholder 
> ID.
> {code}
> String leaseholderName = 
> topologyService.getById(primaryReplicaEvent.leaseholderId()).name();
> updatePrimaryReplica(tablePartitionId, primaryReplicaEvent.startTime(), 
> leaseholderName);
> {code}
> # The lesholder property should be removed from the event parameters.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to