[
https://issues.apache.org/jira/browse/IGNITE-21203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805127#comment-17805127
]
Yury Gerzhedovich commented on IGNITE-21203:
--------------------------------------------
[~korlov] LGTM, thanks
> flaky org.apache.ignite.internal.sql.api.ItSqlAsynchronousApiTest.closeSession
> ------------------------------------------------------------------------------
>
> Key: IGNITE-21203
> URL: https://issues.apache.org/jira/browse/IGNITE-21203
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Reporter: Yury Gerzhedovich
> Assignee: Konstantin Orlov
> Priority: Major
> Labels: ignite-3
> Fix For: 3.0.0-beta2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The test
> org.apache.ignite.internal.sql.api.ItSqlAsynchronousApiTest.closeSession is
> flacky due to org.apache.ignite.internal.sql.api.SessionImpl#close relies on
> the fact that the returned CompletableFuture will be complited only after all
> resources have been closed. However,
> org.apache.ignite.internal.sql.api.SessionImpl#closeAsync returns a always
> ready facke CompletableFuture.
> The closeInternal() method needs to be slightly reworked to return a real
> CompletableFuture and start using the return value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
