[ https://issues.apache.org/jira/browse/IGNITE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815167#comment-17815167 ]
Denis Chudov edited comment on IGNITE-21247 at 2/7/24 8:54 AM: --------------------------------------------------------------- Under this ticket the printing of lease statistics was added: {code:java} [2024-02-07T10:47:31,387][INFO ][%iinrt_dosor_0%lease-updater-1][LeaseUpdater] Leases updated (printed once per 10 iteration(s)): [inCurrentIteration=LeaseStats [leasesCreated=3, leasesPublished=0, leasesProlonged=0, leasesWithoutCandidates=0], active=0, currentAssignmentsSize=3].{code} * {*}inCurrentIteration{*}: leases that were processed in the iteration of LeaseUpdater that printed this log message. {*}leasesCreated{*}: how many leases were created (and negotiation started), {*}leasesPublished{*}: how many of them were published after successful negotiation, {*}leasesProlonged{*}: how many were prolonged, {*}leasesWithoutCandidate{*}: leases that had to be created or prolonged but there was no leaseholder candidate for them. * {*}active{*}: active leases (accepted and not outdated) * {*}currentAssignmentsSize{*}: total assignments list size, that is processed (number of replication groups). was (Author: denis chudov): Under this ticket the printing of lease statistics was added: {code:java} [2024-02-07T10:47:31,387][INFO ][%iinrt_dosor_0%lease-updater-1][LeaseUpdater] Leases updated (printed once per 10 iteration(s)): [inCurrentIteration=LeaseStats [leasesCreated=3, leasesPublished=0, leasesProlonged=0, leasesWithoutCandidates=0], active=0, currentAssignmentsSize=3].{code} > Log enhancements for LeaseUpdater > --------------------------------- > > Key: IGNITE-21247 > URL: https://issues.apache.org/jira/browse/IGNITE-21247 > Project: Ignite > Issue Type: Improvement > Reporter: Denis Chudov > Assignee: Denis Chudov > Priority: Major > Labels: ignite-3 > Time Spent: 50m > Remaining Estimate: 0h > > In > [https://ci.ignite.apache.org/viewLog.html?buildId=7754161&buildTypeId=ApacheIgnite3xGradle_Test_RunAllTests] > , test failure of > {{{}org.apache.ignite.internal.raftsnapshot.ItTableRaftSnapshotsTest: > leaderFeedsFollowerWithSnapshot{}}}, we see that there are no log messages on > replica about lease negotiation, which means that it didn't even started on > the placement driver active actor's side. But the active actor has started > before. Log doesn't provide any information about the detail what happened on > LeaseUpdater. > The suggestion is to add logging to know whether some exception happened in > {{{}updateLeaseBatchInternal{}}}, or in {{{}LeaseNegotiator#negotiate{}}}, > and logging of lease updating statistics (how many groups without > leaseholders were detected, how many negotiations are in progress, how many > leases are prolonged). -- This message was sent by Atlassian Jira (v8.20.10#820010)