[ 
https://issues.apache.org/jira/browse/IGNITE-21467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818710#comment-17818710
 ] 

Viacheslav Blinov commented on IGNITE-21467:
--------------------------------------------

Modernizer can't be replaced with PMD or CheckStyle – there are no appropriate 
rules for that. However, we can replace Modernized with Spotbugs. Spotbugs can 
also give us additional benefits, most noticeable Closable that is not closed 
escape analysis. 
Created IGNITE-21569 for work related to Spotbugs.

> Improve PMD and Checkstyle rulesets
> -----------------------------------
>
>                 Key: IGNITE-21467
>                 URL: https://issues.apache.org/jira/browse/IGNITE-21467
>             Project: Ignite
>          Issue Type: Improvement
>          Components: build
>            Reporter: Mikhail Pochatkin
>            Assignee: Viacheslav Blinov
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> # Remove modernizer plugin and migrate all rules to PMD\Checkstyle. 
> check-rules/modernizer-rules.xml
>  # Introduce separate checkstyle ruleset for public API module (modules/api). 
> This ruleset should be more strict than internal one:
>  ## All public method must have Javadocs (currently in internal code field 
> getters may haven't Javadocs)
>  ## /** \{@inheritDoc} */ is not applicable for public API



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to