[ 
https://issues.apache.org/jira/browse/IGNITE-20981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viacheslav Blinov reassigned IGNITE-20981:
------------------------------------------

    Assignee: Viacheslav Blinov

> Add more PMD rules
> ------------------
>
>                 Key: IGNITE-20981
>                 URL: https://issues.apache.org/jira/browse/IGNITE-20981
>             Project: Ignite
>          Issue Type: Task
>            Reporter:  Kirill Sizov
>            Assignee: Viacheslav Blinov
>            Priority: Major
>              Labels: ignite-3
>
> These rules will help fixing the issues in the codebase.
> The motivation behind picking these ones was to make the code cleaner with as 
> little code changes as possible. Other rules seem to require a dedicated 
> discussion before applying, as they impose more restrictions on the code and 
> might not fit Ignite.
> {code}
>    <rule ref="category/java/bestpractices.xml/AvoidPrintStackTrace" />
>     <rule 
> ref="category/java/bestpractices.xml/AvoidReassigningCatchVariables" />
>     <rule ref="category/java/bestpractices.xml/AvoidReassigningLoopVariables" 
> />
>     <rule ref="category/java/bestpractices.xml/AvoidReassigningParameters" />
>     <rule ref="category/java/bestpractices.xml/MissingOverride" />
>     <rule ref="category/java/bestpractices.xml/OneDeclarationPerLine">
>         <properties>
>             <property name="strictMode" value="true" />
>         </properties>
>     </rule>
>     <rule ref="category/java/bestpractices.xml/ReplaceHashtableWithMap" />
>     <rule ref="category/java/bestpractices.xml/ReplaceVectorWithList" />
>     <rule ref="category/java/bestpractices.xml/SimplifiableTestAssertion" />
>     <rule ref="category/java/bestpractices.xml/UseCollectionIsEmpty" />
>     <rule ref="category/java/codestyle.xml/AvoidDollarSigns" />
>     <rule ref="category/java/codestyle.xml/AvoidProtectedFieldInFinalClass" />
>     <rule 
> ref="category/java/codestyle.xml/AvoidProtectedMethodInFinalClassNotExtending"
>  />
>     <rule ref="category/java/codestyle.xml/ControlStatementBraces" />
>     <rule ref="category/java/codestyle.xml/ExtendsObject" />
>     <rule 
> ref="category/java/codestyle.xml/FieldDeclarationsShouldBeAtStartOfClass" />
>     <rule ref="category/java/codestyle.xml/UnnecessaryCast" />
>     <rule ref="category/java/codestyle.xml/UnnecessaryFullyQualifiedName" />
>     <rule ref="category/java/codestyle.xml/UnnecessaryModifier" />
>     <rule ref="category/java/codestyle.xml/UnnecessaryReturn" />
>     <rule ref="category/java/codestyle.xml/UnnecessarySemicolon" />
>     <rule ref="category/java/codestyle.xml/UseDiamondOperator" />
>     <rule ref="category/java/codestyle.xml/UselessParentheses" />
>     <rule 
> ref="category/java/errorprone.xml/AvoidBranchingStatementAsLastInLoop" />
>     <rule ref="category/java/errorprone.xml/AvoidCallingFinalize" />
>     <rule ref="category/java/errorprone.xml/ComparisonWithNaN" />
>     <rule ref="category/java/errorprone.xml/DontUseFloatTypeForLoopIndices" />
>     <rule ref="category/java/errorprone.xml/EqualsNull" />
>     <rule ref="category/java/errorprone.xml/IdempotentOperations" />
>     <rule ref="category/java/errorprone.xml/JumbledIncrementer" />
>     <rule ref="category/java/errorprone.xml/MisplacedNullCheck" />
>     <rule ref="category/java/errorprone.xml/MoreThanOneLogger" />
>     <rule ref="category/java/errorprone.xml/ReturnFromFinallyBlock" />
>     <rule ref="category/java/errorprone.xml/SimpleDateFormatNeedsLocale" />
>     <rule 
> ref="category/java/errorprone.xml/SingletonClassReturningNewInstance" />
>     <rule ref="category/java/errorprone.xml/SuspiciousEqualsMethodName" />
>     <rule ref="category/java/errorprone.xml/SuspiciousHashcodeMethodName" />
>     <rule ref="category/java/errorprone.xml/SuspiciousOctalEscape" />
>     <rule ref="category/java/errorprone.xml/UnconditionalIfStatement" />
>     <rule ref="category/java/errorprone.xml/UnnecessaryBooleanAssertion" />
>     <rule ref="category/java/errorprone.xml/UnnecessaryCaseChange" />
>     <rule ref="category/java/errorprone.xml/UnnecessaryConversionTemporary" />
>     <rule ref="category/java/errorprone.xml/UnusedNullCheckInEquals" />
>     <rule ref="category/java/errorprone.xml/UseCorrectExceptionLogging" />
>     <rule ref="category/java/errorprone.xml/UseEqualsToCompareStrings" />
>     <rule ref="category/java/errorprone.xml/NonStaticInitializer" />
>     <rule ref="category/java/errorprone.xml/OverrideBothEqualsAndHashcode" />
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to