[ 
https://issues.apache.org/jira/browse/IGNITE-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824018#comment-17824018
 ] 

Pavel Pereslegin commented on IGNITE-18757:
-------------------------------------------

One such check was implemented in {{SqlEngineModuleArchTest}}.

> Sql. Add arch unit tests for classes that inherited from Calcite classes.
> -------------------------------------------------------------------------
>
>                 Key: IGNITE-18757
>                 URL: https://issues.apache.org/jira/browse/IGNITE-18757
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>            Reporter: Andrey Mashenkov
>            Priority: Major
>              Labels: ignite-3, tech-debt
>             Fix For: 3.0.0-beta2
>
>
> Motivation: as of now, it is easy to miss/forget to override methods, when 
> inherit from Calcite classes.
> E.g. from time to time we forget to override methods for deriving/passing 
> through traits or passing shuttle.
> We can use ArchUnit to make additional checks that all required methods are 
> overridden.
> As an example, see static logger checks in ClientArchTest.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to