[
https://issues.apache.org/jira/browse/IGNITE-21695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viacheslav Blinov updated IGNITE-21695:
---------------------------------------
Description:
Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
M D UCF_USELESS_CONTROL_FLOW UCF: Useless control flow in
org.apache.ignite.internal.pagememory.util.PageHandler.<static initializer for
PageHandler>() At PageHandler.java:[line 34]
{noformat}
One of the conditions of this interface default implementation checks for
condition which is always true/false. This can be a sign of a bug.
Investigate whenever this is a false-positive and we should suppress it, or we
should make a proper fix.
At the result of investigation corresponding TODO should be removed in
spotbugs-excludes.xml
was:
Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
M P WMI_WRONG_MAP_ITERATOR WMI:
org.apache.ignite.internal.tx.impl.HeapLockManager$WaiterImpl.recalculate()
makes inefficient use of keySet iterator instead of entrySet iterator At
HeapLockManager.java:[line 815]
M P WMI_WRONG_MAP_ITERATOR WMI:
org.apache.ignite.internal.tx.impl.HeapUnboundedLockManager$WaiterImpl.recalculate()
makes inefficient use of keySet iterator instead of entrySet iterator At
HeapUnboundedLockManager.java:[line 632] {noformat}
This method accesses the value of a Map entry, using a key that was retrieved
from a keySet iterator. It is more efficient to use an iterator on the entrySet
of the map, to avoid the Map.get(key) lookup.
Investigate whenever this is a false-positive and we should suppress it, or we
should make a proper fix.
At the result of investigation corresponding TODO should be removed in
spotbugs-excludes.xml
> PageHandler: useless control flow
> ---------------------------------
>
> Key: IGNITE-21695
> URL: https://issues.apache.org/jira/browse/IGNITE-21695
> Project: Ignite
> Issue Type: Bug
> Reporter: Viacheslav Blinov
> Priority: Major
>
> Issue detected by SpotBugs. Specifically the warning reported is:
> {noformat}
> M D UCF_USELESS_CONTROL_FLOW UCF: Useless control flow in
> org.apache.ignite.internal.pagememory.util.PageHandler.<static initializer
> for PageHandler>() At PageHandler.java:[line 34]
> {noformat}
> One of the conditions of this interface default implementation checks for
> condition which is always true/false. This can be a sign of a bug.
> Investigate whenever this is a false-positive and we should suppress it, or
> we should make a proper fix.
> At the result of investigation corresponding TODO should be removed in
> spotbugs-excludes.xml
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
