[
https://issues.apache.org/jira/browse/IGNITE-21700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viacheslav Blinov updated IGNITE-21700:
---------------------------------------
Description:
Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
H D RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT RV: Return value of
org.apache.calcite.plan.RelOptCost.plus(RelOptCost) ignored, but method has no
side effect At IgniteSort.java:[line 169] {noformat}
It looks like RelOptCost.plus is side-effect free and it's return result should
be used, but it is ignored! It looks like a bug!
Investigate whenever this is a false-positive and we should suppress it, or
make a proper fix.
At the result of investigation corresponding TODO should be removed in
spotbugs-excludes.xml
was:
Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
M B ES_COMPARING_STRINGS_WITH_EQ ES: Comparison of String objects using == or
!= in
org.apache.ignite.internal.sql.engine.trait.DistributionFunction.equals(Object)
At DistributionFunction.java:[line 76]
M B ES_COMPARING_STRINGS_WITH_EQ ES: Comparison of String objects using == or
!= in
org.apache.ignite.internal.sql.engine.trait.DistributionFunction.satisfy(DistributionFunction,
DistributionFunction) At DistributionFunction.java:[line 117]
{noformat}
This might be wrong.
Investigate whenever this is a false-positive and we should suppress it, or
make a proper fix.
At the result of investigation corresponding TODO should be removed in
spotbugs-excludes.xml
> IgniteSort: result of RelOptCost.plus is ignored but it doesn't have
> side-effects
> ---------------------------------------------------------------------------------
>
> Key: IGNITE-21700
> URL: https://issues.apache.org/jira/browse/IGNITE-21700
> Project: Ignite
> Issue Type: Bug
> Reporter: Viacheslav Blinov
> Priority: Minor
>
> Issue detected by SpotBugs. Specifically the warning reported is:
> {noformat}
> H D RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT RV: Return value of
> org.apache.calcite.plan.RelOptCost.plus(RelOptCost) ignored, but method has
> no side effect At IgniteSort.java:[line 169] {noformat}
> It looks like RelOptCost.plus is side-effect free and it's return result
> should be used, but it is ignored! It looks like a bug!
> Investigate whenever this is a false-positive and we should suppress it, or
> make a proper fix.
> At the result of investigation corresponding TODO should be removed in
> spotbugs-excludes.xml
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
