[
https://issues.apache.org/jira/browse/IGNITE-21701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viacheslav Blinov updated IGNITE-21701:
---------------------------------------
Description:
Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
M C EC_UNRELATED_TYPES_USING_POINTER_EQUALITY EC: Using pointer equality to
compare a org.apache.calcite.rel.RelDistributions$RelDistributionImpl with a
org.apache.ignite.internal.sql.engine.trait.IgniteDistribution in new
org.apache.ignite.internal.sql.engine.rel.IgniteSender(RelOptCluster,
RelTraitSet, RelNode, long, long, IgniteDistribution) At
IgniteSender.java:[line 58]
{noformat}
It looks like a bug because this comparsion will always yield false!
Investigate whenever this is a false-positive and we should suppress it, or
make a proper fix.
At the result of investigation corresponding TODO should be removed in
spotbugs-excludes.xml
was:
Issue detected by SpotBugs. Specifically the warning reported is:
{noformat}
H D RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT RV: Return value of
org.apache.calcite.plan.RelOptCost.plus(RelOptCost) ignored, but method has no
side effect At IgniteSort.java:[line 169] {noformat}
It looks like RelOptCost.plus is side-effect free and it's return result should
be used, but it is ignored! It looks like a bug!
Investigate whenever this is a false-positive and we should suppress it, or
make a proper fix.
At the result of investigation corresponding TODO should be removed in
spotbugs-excludes.xml
> IgniteSender compares unrelated types
> -------------------------------------
>
> Key: IGNITE-21701
> URL: https://issues.apache.org/jira/browse/IGNITE-21701
> Project: Ignite
> Issue Type: Bug
> Reporter: Viacheslav Blinov
> Priority: Major
>
> Issue detected by SpotBugs. Specifically the warning reported is:
> {noformat}
> M C EC_UNRELATED_TYPES_USING_POINTER_EQUALITY EC: Using pointer equality to
> compare a org.apache.calcite.rel.RelDistributions$RelDistributionImpl with a
> org.apache.ignite.internal.sql.engine.trait.IgniteDistribution in new
> org.apache.ignite.internal.sql.engine.rel.IgniteSender(RelOptCluster,
> RelTraitSet, RelNode, long, long, IgniteDistribution) At
> IgniteSender.java:[line 58]
> {noformat}
> It looks like a bug because this comparsion will always yield false!
> Investigate whenever this is a false-positive and we should suppress it, or
> make a proper fix.
> At the result of investigation corresponding TODO should be removed in
> spotbugs-excludes.xml
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
