[
https://issues.apache.org/jira/browse/IGNITE-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385755#comment-15385755
]
Anton Vinogradov commented on IGNITE-3303:
------------------------------------------
Saikat,
I've made a couple of fixes related to codestyle and etc.
https://github.com/avinogradovgg/ignite/commit/982f11eca52f3685a1d103f79b97cc13d3fd4749
please cherrypick them.
Also,
1) I've added some todos, please fix them.
2) I don't like to set static fiels at constructor. Please replace static
fields by non-static.
Also, I see no reason to have default values (eg evtBufTimeout = 10) in case
you'll override them at constructor.
As for me, better to use setters with final static default values (see
CacheConfiguration for example).
3) Please add more checks to test to make sure everything is works as designed.
Thanks!
> Apache Flink Integration - Flink source to run a continuous query against one
> or multiple caches
> ------------------------------------------------------------------------------------------------
>
> Key: IGNITE-3303
> URL: https://issues.apache.org/jira/browse/IGNITE-3303
> Project: Ignite
> Issue Type: New Feature
> Components: streaming
> Reporter: Saikat Maitra
> Assignee: Anton Vinogradov
>
> Apache Flink integration
> +++ *Ignite as a bidirectional Connector* +++
> As a Flink source => run a continuous query against one or multiple
> caches [4].
> Related discussion :
> http://apache-ignite-developers.2346864.n4.nabble.com/Apache-Flink-lt-gt-Apache-Ignite-integration-td8163.html
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
