[ 
https://issues.apache.org/jira/browse/IGNITE-22026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Shishkov updated IGNITE-22026:
-----------------------------------
    Description: 
GridCacheIoManager#send[1] and GridCacheIoManager#sendOrderedMessage[2] have 
incorrect retryCnt comparison in catch block and real retries count will be one 
less, than configured.

If you set retryCnt to 1 and IgniteCheckedException has been thrown, then no 
actual retries  will happen.

Reproducer: 

Links:
# 
https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1222
# 
https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1289

  was:
GridCacheIoManager#send[1] and GridCacheIoManager#sendOrderedMessage[2] have 
incorrect retryCnt comparison in catch block and real retries count will be one 
less, than configured.

If you set retryCnt to 1 and IgniteCheckedException has been thrown, then no 
actual retries  will happen.

Links:
# 
https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1222
# 
https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1289


> Fix incorrect retry logic in GridCacheIoManager send method
> -----------------------------------------------------------
>
>                 Key: IGNITE-22026
>                 URL: https://issues.apache.org/jira/browse/IGNITE-22026
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Ilya Shishkov
>            Priority: Minor
>              Labels: ise
>         Attachments: GridCacheIoManagerRetryTest.patch
>
>
> GridCacheIoManager#send[1] and GridCacheIoManager#sendOrderedMessage[2] have 
> incorrect retryCnt comparison in catch block and real retries count will be 
> one less, than configured.
> If you set retryCnt to 1 and IgniteCheckedException has been thrown, then no 
> actual retries  will happen.
> Reproducer: 
> Links:
> # 
> https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1222
> # 
> https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1289



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to