[
https://issues.apache.org/jira/browse/IGNITE-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Orlov resolved IGNITE-17287.
---------------------------------------
Resolution: Invalid
SchemaSerializerImpl was removed in IGNITE-19744
> SchemaSerializerImpl and ClientMessagePacker have the same types (un)pack
> code functionality, deduplication needed.
> -------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-17287
> URL: https://issues.apache.org/jira/browse/IGNITE-17287
> Project: Ignite
> Issue Type: Improvement
> Components: sql
> Affects Versions: 3.0.0-beta1
> Reporter: Evgeny Stanilovsky
> Priority: Major
> Labels: ignite-3
>
> ByteBuffer vs Netty.ByteBuf are also difference, but seems its not a problem.
> Check for example:
> ClientMessagePacker#packDateTime:
> {code:java}
> public void packDateTime(LocalDateTime val) {
> packExtensionTypeHeader(ClientMsgPackType.DATETIME);
> buf.writeInt(val.getYear());
> buf.writeByte(val.getMonthValue());
> buf.writeByte(val.getDayOfMonth());
> buf.writeByte(val.getHour());
> buf.writeByte(val.getMinute());
> buf.writeByte(val.getSecond());
> buf.writeInt(val.getNano());
> }
> {code}
> SchemaSerializerImpl#appendDefaultValue
> {code:java}
> case DATETIME: {
> LocalDateTime date = (LocalDateTime) val;
> buf.putInt(date.getYear());
> buf.put((byte) date.getMonthValue());
> buf.put((byte) date.getDayOfMonth());
> buf.put((byte) date.getHour());
> buf.put((byte) date.getMinute());
> buf.put((byte) date.getSecond());
> buf.putInt(date.getNano());
> break;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
