[ 
https://issues.apache.org/jira/browse/IGNITE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Steshin updated IGNITE-22182:
--------------------------------------
    Description: 
In the the snapshot validation, we do some metaadas checks within 
`IgniteSnapshotManager` instead of dedicated 
`SnapshotMetadataVerificationTask`. Like:
{code:java}
if (masterKeyDigest == null && snpMasterKeyDigest != null) {
                            res.onDone(new 
SnapshotPartitionsVerifyTaskResult(metas, new IdleVerifyResultV2(
                                Collections.singletonMap(cctx.localNode(), new 
IllegalArgumentException("Snapshot '" +
                                    meta.snapshotName() + "' has encrypted 
caches while encryption is disabled. To " +
                                    "restore this snapshot, start Ignite with 
configured encryption and the same " +
                                    "master key.")))));

                            return;
}
{code}

Suck checks should be moved to the task.


  was:
In the the snapshot validation, we do some meatadas checks within 
`IgniteSnapshotManager` instead dedicated `SnapshotMetadataVerificationTask`. 
Like:
{code:java}
if (masterKeyDigest == null && snpMasterKeyDigest != null) {
                           res.onDone(new 
SnapshotPartitionsVerifyTaskResult(metas, new IdleVerifyResultV2(
                                Collections.singletonMap(cctx.localNode(), new 
IllegalArgumentException("Snapshot '" +
                                    meta.snapshotName() + "' has encrypted 
caches while encryption is disabled. To " +
                                    "restore this snapshot, start Ignite with 
configured encryption and the same " +
                                    "master key.")))));

                            return;
}
{code}

Suck checks should be moved to the task.



> Move snapshop metadata validation to SnapshotMetadataVerificationTask
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-22182
>                 URL: https://issues.apache.org/jira/browse/IGNITE-22182
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vladimir Steshin
>            Priority: Minor
>
> In the the snapshot validation, we do some metaadas checks within 
> `IgniteSnapshotManager` instead of dedicated 
> `SnapshotMetadataVerificationTask`. Like:
> {code:java}
> if (masterKeyDigest == null && snpMasterKeyDigest != null) {
>                             res.onDone(new 
> SnapshotPartitionsVerifyTaskResult(metas, new IdleVerifyResultV2(
>                                 Collections.singletonMap(cctx.localNode(), 
> new IllegalArgumentException("Snapshot '" +
>                                     meta.snapshotName() + "' has encrypted 
> caches while encryption is disabled. To " +
>                                     "restore this snapshot, start Ignite with 
> configured encryption and the same " +
>                                     "master key.")))));
>                             return;
> }
> {code}
> Suck checks should be moved to the task.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to