[
https://issues.apache.org/jira/browse/IGNITE-22182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850035#comment-17850035
]
Ignite TC Bot commented on IGNITE-22182:
----------------------------------------
{panel:title=Branch: [pull/11346/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/11346/head] Base: [master] : No new tests
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}{panel}
[TeamCity *--> Run :: All*
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=7888460&buildTypeId=IgniteTests24Java8_RunAll]
> Move snapshop metadata validation to SnapshotMetadataVerificationTask
> ---------------------------------------------------------------------
>
> Key: IGNITE-22182
> URL: https://issues.apache.org/jira/browse/IGNITE-22182
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladimir Steshin
> Assignee: Vladimir Steshin
> Priority: Minor
> Labels: ise
> Fix For: 2.17
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In the the snapshot validation, we do some metadata checks within
> `IgniteSnapshotManager` instead of dedicated
> `SnapshotMetadataVerificationTask`. Like:
> {code:java}
> if (masterKeyDigest == null && snpMasterKeyDigest != null) {
> res.onDone(new SnapshotPartitionsVerifyTaskResult(metas, new
> IdleVerifyResultV2(
> Collections.singletonMap(cctx.localNode(), new
> IllegalArgumentException("Snapshot '" +
> meta.snapshotName() + "' has encrypted caches while encryption is
> disabled. To " +
> "restore this snapshot, start Ignite with configured encryption
> and the same " +
> "master key.")))));
> return;
> }
> {code}
> Such checks should be moved to the task.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
