[ 
https://issues.apache.org/jira/browse/IGNITE-22287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850695#comment-17850695
 ] 

Pavel Tupitsyn commented on IGNITE-22287:
-----------------------------------------

Turns out we need the scale to preserve original `BigDecimal` representation in 
Java. If we remove it, tests fail with errors like:

```
Unexpected string representation of value ==> expected: <10> but was: <1E+1>
in 
org.apache.ignite.internal.runner.app.client.ItThinClientComputeTest.testAllSupportedArgTypes)
```

and

```
org.opentest4j.AssertionFailedError: expected: <112000> but was: <1.12E+5>
in 
org.apache.ignite.internal.runner.app.client.ItThinClientComputeTest.testBigDecimalPropagation([3]
 1.12E5, 0)
```

> Remove decimal scale from packObjectAsBinaryTuple
> -------------------------------------------------
>
>                 Key: IGNITE-22287
>                 URL: https://issues.apache.org/jira/browse/IGNITE-22287
>             Project: Ignite
>          Issue Type: Improvement
>          Components: thin client
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Major
>              Labels: ignite-3
>             Fix For: 3.0.0-beta2
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> IGNITE-21745 adds decimal scale as part of the binary tuple payload. We no 
> longed need to send it separately in 
> *ClientBinaryTupleUtils#appendTypeAndScale*.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to